Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed existing collaborators in autocomplete #2724

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Fixed existing collaborators in autocomplete #2724

merged 1 commit into from
Dec 17, 2019

Conversation

LukasHirt
Copy link
Contributor

Description

Do not hide collaborator if another entry with the same name exists if they are not the same type.

Related Issue

How Has This Been Tested?

  • test environment: Acceptance tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Dec 17, 2019
@LukasHirt LukasHirt self-assigned this Dec 17, 2019
@LukasHirt LukasHirt force-pushed the bugfix/sharing-with-group-and-user branch from 4c0e77d to df58796 Compare December 17, 2019 13:00
PVince81
PVince81 approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt force-pushed the bugfix/sharing-with-group-and-user branch from df58796 to c8acbda Compare December 17, 2019 13:55
@PVince81 PVince81 merged commit 812731e into master Dec 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/sharing-with-group-and-user branch December 17, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

creating share with user and group having same name is not possible
2 participants
@LukasHirt @PVince81