Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented virtual scroll in trash bin #2809

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Implemented virtual scroll in trash bin #2809

merged 1 commit into from
Jan 8, 2020

Conversation

LukasHirt
Copy link
Contributor

Description

Re-use FileList component with the virtual scroll inside of trash bin.

Related Issue

How Has This Been Tested?

  • test environment: Drone

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Jan 3, 2020
@LukasHirt LukasHirt self-assigned this Jan 3, 2020
@LukasHirt LukasHirt force-pushed the feature/trashbin-virtual-scroll branch 2 times, most recently from bbbf291 to 2838d93 Compare January 3, 2020 10:19
@LukasHirt
Implemented virtual scroll in trashbin
f3a4084 
Adjusted selectors

Fixed toggle selector

Fixed selectors
@LukasHirt LukasHirt force-pushed the feature/trashbin-virtual-scroll branch from 2838d93 to f3a4084 Compare January 7, 2020 15:22
PVince81
PVince81 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine 👍

Glad to see that Trashbin is now also using the FileList base view

@PVince81 PVince81 merged commit f25b04a into master Jan 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/trashbin-virtual-scroll branch January 8, 2020 08:29
@fschade fschade mentioned this pull request Apr 29, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement virtual scroll in trashbin
2 participants
@LukasHirt @PVince81