Adjust labels in "new" menu in files app #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "Create new" with "New" as it makes it look less cluttered when trying to spot a matching entry. Added changelog entry for this one and also another column header change.
PVince81
force-pushed
the
adjust-newmenu-labels
branch
from
a8acb11
to
0a1b66e
Compare
pmaier1
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Actually this is still doubled, as you have "+ New" on the button, but it's better than before. Current UI would just say "Folder" which I like better. Others have two buttons, one for Upload, one for Create and the entries are "Folder", "Word Document", etc..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace "Create new" with "New" as it makes it look less cluttered when
trying to spot a matching entry.
Added changelog entry for this one and also another column header
change.
Related Issue
None raised, quick fix.
Motivation and Context
See description
How Has This Been Tested?
Manual test, see screenshot
Screenshots (if appropriate):
Types of changes
Checklist: