Remove filter button #2972
Merged
Remove filter button #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
approved these changes
Feb 5, 2020
kulmann
approved these changes
Feb 5, 2020
Removes the ability to filter by files and folders, which was never an explicit requirement. Removes the ability to toggle hidden files, hidden files will always be shown by default. We will reconsider adding this checkbox back somewhere else at some point. Removes the filter text search, which is redundant of the global search box.
PVince81
force-pushed
the
remove-filter-button
branch
from
e38d32d
to
c7428a6
Compare
|
removed further tests related to hiding hidden files and squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the ability to filter by files and folders, which was never an
explicit requirement.
Removes the ability to toggle hidden files, hidden files will always be
shown by default. We will reconsider adding this checkbox back somewhere
else at some point.
Removes the filter text search, which is redundant of the global search box.
Related Issue
Fixes #2971
Motivation and Context
How Has This Been Tested?
Tests removed, CI will confirm if everything still works fine.
Manual test in UI, no errors visible.
Screenshots (if appropriate):
Types of changes
Checklist: