-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve collaborators and owner columns in shared file lists #3049
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
87c869e
to
1140318
Compare
This is only a stepping stone as we will consider merging "shared with me" with "shared with others" view into a single one, so it will likely evolve further from here |
Failed tests:
|
1140318
to
bf877c2
Compare
data structure aligned |
bf877c2
to
5a92257
Compare
row height issue unrelated to this PR => #3099 |
rebased and squashed. next up will be adding/fixing tests |
5a92257
to
ee341b5
Compare
added and fixed tests, let's hope all pass now |
raised #3101 which I discovered while trying to extend the test coverage |
ee341b5
to
43fbe40
Compare
I'll adjust the tests later in the morning (not saying tomorrow as it's past midnight...) |
When sharing with multiple targets, they must all be listed there instead of a single entry. This is fixed by replacing the code that make share entries unique into an aggregation that has been inspired by the one used in OC core. Also includes group shares and link shares now. Added avatars and icons for the displayed collaborators in the column.
43fbe40
to
ee0f8f5
Compare
tests adjusted background: the main reason for all these changes is that before this PR we were using |
Description
When sharing with multiple targets, they must all be listed there instead of a single entry. This is fixed by replacing the code that make share entries unique into an aggregation that has been inspired by the one used in OC core.
Also includes group shares and link shares now.
Added avatars and icons for the displayed collaborators in the column.
Related Issue
Fixes #2924
Motivation and Context
Just doing a bugfix was too boring, but also the column contents didn't look very nice, so adding avatars there was a good move IMO.
How Has This Been Tested?
Manual test
Acceptance tests
Screenshots (if appropriate):
Shared with others
Shared with you
Types of changes
Checklist:
Open tasks: