Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align columns to right #3163

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Align columns to right #3163

merged 1 commit into from
Mar 11, 2020

Conversation

LukasHirt
Copy link
Collaborator

Description

Aligned columns to the right and hide indicators which are inactive.

Related Issue

Motivation and Context

Easy comparison between rows for the user.

How Has This Been Tested?

  • test environment: Manually

Screenshots (if appropriate):

image

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Mar 9, 2020
@LukasHirt LukasHirt requested a review from PVince81 March 9, 2020 14:20
@LukasHirt LukasHirt self-assigned this Mar 9, 2020
@update-docs
Copy link

update-docs bot commented Mar 9, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt force-pushed the feature/align-columns-right branch from 29c577d to 4f582f7 Compare March 9, 2020 14:22
@PVince81
Copy link
Contributor

It was an explicit requirement for the share indicators to not be aligned to the right. Might have been from @pmaier1. @pmaier1 are you ok with the change, see screenshot.

@pmaier1
Copy link
Contributor

pmaier1 commented Mar 10, 2020

If you think that's better, I'm fine with it.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

apps/files/src/components/AllFilesList.vue Outdated Show resolved Hide resolved
@PVince81 PVince81 merged commit 3c080b5 into master Mar 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/align-columns-right branch March 11, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align columns in files list to the right
3 participants