Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed share indicator delay #3213

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fixed share indicator delay #3213

merged 1 commit into from
Mar 23, 2020

Conversation

Julian1998
Copy link
Contributor

Description

Load the share (default) indicators in the general file list component first and pass them down.

Related Issue

Motivation and Context

Bugfix

How Has This Been Tested?

  • Using Chrome

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@Julian1998 Julian1998 added the Status:Needs-Review Needs review from a maintainer label Mar 20, 2020
@Julian1998 Julian1998 self-assigned this Mar 20, 2020
@update-docs
Copy link

update-docs bot commented Mar 20, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@Julian1998 Julian1998 force-pushed the bugfix/fix-sharing-indicator-delay branch from e822cd3 to 390570d Compare March 20, 2020 14:50
@Julian1998
Copy link
Contributor Author

@LukasHirt Is the changelog correct? It's my first :)

@Julian1998 Julian1998 force-pushed the bugfix/fix-sharing-indicator-delay branch 2 times, most recently from 744ad0e to 7e94096 Compare March 20, 2020 15:06
@Julian1998 Julian1998 force-pushed the bugfix/fix-sharing-indicator-delay branch from 7e94096 to f988d9b Compare March 20, 2020 16:50
@PVince81 PVince81 merged commit 0e314a0 into master Mar 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/fix-sharing-indicator-delay branch March 23, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@Julian1998 Julian1998

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share indicators appear delayed
3 participants
@Julian1998 @LukasHirt @PVince81