Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog prompt message fix #3240

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Dialog prompt message fix #3240

merged 1 commit into from
Apr 9, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 22, 2020 •
edited
Loading

Description

Make error messages in dialog prompts less annoying.
Within the dialog prompt for several small tasks (e.g. creating a new folder) there are three things changed:

  1. the error message is now shown below the input field, using new properties from oc-text-input in ODS.
  2. the changes on error messages are debounced for 400 milliseconds. As a result error messages that would appear during typing (like if you type a folder name which contains a blank in between two words) are not shown at all (if you type more than 1 character every 400 milliseconds).

Related Issue

Motivation and Context

UX improvement

How Has This Been Tested?

Screenshots (if appropriate):

jumpy error message gone

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Mar 22, 2020
@kulmann kulmann self-assigned this Mar 22, 2020
@update-docs
Copy link

update-docs bot commented Mar 22, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt
Copy link
Collaborator

Pls post a screenshot into description

@LukasHirt
Copy link
Collaborator

It still feels strange since the dialog is still kind of "jumpy". Just in a different way.

I'd still say that a solution like this would be better way to go:

image

@kulmann
Copy link
Member Author

kulmann commented Mar 24, 2020

@LukasHirt @PVince81 using the feature from here owncloud/owncloud-design-system#690 the input prompt looks like in the screenshots below. Vertical space is reserved, modal layout doesn't jump anymore, except on long messages that break into a second line. What do you think?

Bildschirmfoto 2020-03-24 um 18 23 02
Bildschirmfoto 2020-03-24 um 18 23 20

@LukasHirt
Copy link
Collaborator

IMHO this looks much better 👍

@kulmann kulmann force-pushed the dialog-prompt-message-fix branch 2 times, most recently from 994fb9c to 90bfa36 Compare March 27, 2020 12:21
LukasHirt
LukasHirt approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LukasHirt
Copy link
Collaborator

LukasHirt commented Mar 27, 2020 •
edited
Loading

Agh, tests are failing 🤢 Can you take a look? @kulmann

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9120/

20200327-133648-317.png
20200327-133715-464.png
20200327-133722-819.png
20200327-133723-080.png
20200327-133749-031.png
20200327-133749-291.png
20200327-133756-261.png
20200327-133756-534.png
20200327-133822-768.png
20200327-133822-996.png
20200327-133829-779.png
20200327-133830-011.png
20200327-133837-211.png
20200327-133837-463.png
20200327-133903-449.png
20200327-133903-701.png
20200327-133929-807.png
20200327-133930-066.png
20200327-133937-233.png
20200327-133937-483.png
20200327-134003-346.png
20200327-134003-635.png
20200327-134010-814.png
20200327-134011-054.png
20200327-134037-123.png
20200327-134037-360.png
20200327-134111-330.png
20200327-134111-587.png
20200327-134137-536.png
20200327-134137-765.png
20200327-134203-681.png
20200327-134203-937.png
20200327-134210-922.png
20200327-134211-213.png
20200327-134237-320.png
20200327-134237-571.png
20200327-134303-741.png
20200327-134304-012.png
20200327-134329-902.png
20200327-134330-188.png
20200327-134356-511.png
20200327-134356-769.png
20200327-134632-066.png
20200327-134632-342.png
20200327-134637-833.png
20200327-134638-071.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9122/

20200327-164227-486.png
20200327-164313-307.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9302/

20200407-160842-392.png
20200407-160928-505.png
20200407-161015-950.png
20200407-161045-547.png

@kulmann kulmann force-pushed the dialog-prompt-message-fix branch 5 times, most recently from 08635ec to e64f0a4 Compare April 9, 2020 12:10
@kulmann kulmann merged commit d905fad into master Apr 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the dialog-prompt-message-fix branch April 9, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jumpy error message in folder creation dialog
3 participants
@kulmann @LukasHirt @ownclouders