Fix share expiration date change

[kulmann]

Description

As pointed out in the linked issue we were not showing errors when saving shares in an invalid state. Instead we were going back to the sidebar panel, leaving the user with the impression that the share was saved successfully. Now we show errors that were raised when saving the share - same style as in the public link editing sidebar panel.

While fixing this I noticed, that the public link editing sidebar panel didn't react properly to forced expiration dates anymore (calendar plugin was not picking up the enforced date and the input field was missing the (required) label). So I fixed that as well and applied the same (code) style as in the collaborators editing sidebar panel.

Related Issue

• Partially fixes Expiration date doesn't get updated after changing default expiration days in admin sharing setting #3176

Motivation and Context

Saving shares should show errors if any were raised.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• changelog entry about bugfix

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[individual-it]

Acceptance tests are missing. @kulmann do you want the QA-team to add tests?

[kulmann]

Acceptance tests are missing. @kulmann do you want the QA-team to add tests?

@individual-it yes, that would be great, thanks! 👍

[Talank]

@kulmann is it alright if I take over this PR to write some test and make CI happy?

[kulmann]

@kulmann is it alright if I take over this PR to write some test and make CI happy?

yes, awesome, thanks!

[individual-it]

this test (and one similar) fail because it used to be possible to select an invalid date and then click save the share, but now the invalid dates are greyed out

  Scenario: user cannot set an expiry date when creating a public link to a date that is past the enforced max expiry date
    Given the setting "shareapi_default_expire_date" of app "core" has been set to "yes"
    And the setting "shareapi_enforce_expire_date" of app "core" has been set to "yes"
    And user "user1" has logged in using the webUI
    When the user tries to create a new public link for resource "simple-folder" using the webUI with
      | expireDate | +8 |
    Then the user should see an error message on the public link share dialog saying "Cannot set expiration date more than 7 days in the future"
    And user "user1" should not have created any shares

@kulmann Is that is an expected outcome of your changes?

[individual-it]

@kulmann @Talank I've rebased the branch and force-pushed, so if you work on it please get the most recent version before making changes

[kulmann]

@individual-it @Talank the greyed out invalid dates were like that before. I'm only showing the error alert at the top of the sidebar if the API throws an error on saving.

There could be other errors on saving as well, not only expiration date related. But for expiration dates the error is not reproducible anymore, because as we learned yesterday

a) saving an unchanged invalid date doesn't throw an error anymore
b) selecting a different invalid date is not possible (and already was not before my PR)

The only edge case I can think of is, that an admin shortens the enforced expiration date period AFTER the user has loaded the UI. In that case the user would be able to select an invalid expiration date and receive the error message. IMHO not worth the effort to write tests for it. The more important test in this case is on the API level, not on the UI level.

[kulmann]

@Talank or @individual-it could you please clarify the comment I added? Other than that nice work! 👍

[LukasHirt]

Code-wise LGTM. If tests are completely done then feel free to merge 👍