Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete (and duplicate) error alert #3342

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Apr 14, 2020

Description

Somehow the old oc-alert snuck in in the dialog prompt. When squashing the recent PR which added the new error message in oc-text-input I dropped a commit - I suppose that removing the old oc-alert was part of that commit and I've probably missed that... This PR fixes the dialog prompt by removing it again.

Motivation and Context

Dialog prompt shows the error message twice right now. Once within the oc-text-input component and once as an alert below. Obviously the alert has to be removed.

How Has This Been Tested?

Locally in Chrome and Firefox.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Apr 14, 2020
@kulmann kulmann requested a review from LukasHirt April 14, 2020 15:05
@kulmann kulmann self-assigned this Apr 14, 2020
@update-docs
Copy link

update-docs bot commented Apr 14, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt merged commit 58bc464 into master Apr 14, 2020
@LukasHirt LukasHirt deleted the fix-dialog-prompt branch April 14, 2020 20:16
@micbar micbar mentioned this pull request Apr 28, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants