Add collaborators quick action

[LukasHirt]

Description

Added a new quick action which opens the new collaborators tab in the files list sidebar.

Related Issue

• Refs Quick action: Add collaborator product#80

How Has This Been Tested?

• test environment: Acceptance tests

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Open tasks:

• Rebase after merging quick actions
• Fix clicking on quick action when sidebar is already opened

[LukasHirt]

This PR is built on top of #3573 After it will get merged I will rebase this PR.

[LukasHirt]

There is an issue that when we're switching highlighted file, the current tab and current panel resets. So if we click on the quick action while already having sidebar opened, we land in the default tab

One solution could be to set first the highlighted file to null which would do the reset before we set the new tab. This leads to a "jumpy" sidebar which quickly closes and opened => very ugly.

I'll try to see if there'd be some nicer solution. But I don't want to invest much time into debugging this since we'll change it later to overlay which will hide the quick actions anyway 🤷

[kulmann]

See comment. Also: please remember to bring back

const state = await filesList.isSharingButtonPresent(resource)
assert.ok(!state, `Error: Sharing button for resource ${resource} is not in disabled state`)

after merging https://github.com/owncloud/phoenix/pull/3586/files ;-) you made a comment there.

[kulmann]

IMO this is too specific. What about an options object as an optional second argument for the current sidebar tab? Then we would be able to pass in context specific data without changing the store everytime we add something to the sidebar.

Could be called like this: SET_CURRENT_SIDEBAR_TAB(state, { tab, options: {'collaborators-tab-sub-panel': 'newCollaborator'} }

[LukasHirt]

I still introduced mutation though which sets only options and not the whole tab object. This is because in collaborators we often change only the panel without changing the tab and it would feel strange to always have to define the collaborators' tab all over again.

[LukasHirt]

@kulmann I've brought back the commented out part of tests and introduced the options object. Pls, re-review.

[kulmann]

There is one bug: when I open the sidebar and then click on the link indicator of another row, the sidebar switches to the collaborators tab instead of the links tab... happens reliably in Chrome. Can you confirm that?

[kulmann]

If you want to have store and item as named variables, you can unwrap the ctx like this:
function canShare({ item, store }) {. Of course also fine like it is. 👍

[LukasHirt]

Right, 🤦 I did it already automatically after doing it in the handlers of quickActions. I got rid of the object completely and just pass it in.

[LukasHirt]

There is one bug: when I open the sidebar and then click on the link indicator of another row, the sidebar switches to the collaborators tab instead of the links tab... happens reliably in Chrome. Can you confirm that?

Yes, happens to me as well. I'll jump to debugging first thing tomorrow morning

[LukasHirt]

Fixed the bug. Had to use setTimeout again because the beforeDestroy which resets the tab happened after the links tab has been set.

[kulmann]

🚀