Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade owncloud-sdk #3602

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Upgrade owncloud-sdk #3602

merged 2 commits into from
Jun 15, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 15, 2020

Description

We've updated owncloud-sdk to version 1.0.0-638 which makes sure that an empty array gets returned whenever there are no settings values for the authenticated user. Previously having no settings values broke our detection of whether settings values finished loading.

Related Issue

Motivation and Context

Fixes a bug

How Has This Been Tested?

Local chrome + firefox.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Jun 15, 2020
@kulmann kulmann requested a review from LukasHirt June 15, 2020 07:18
@kulmann kulmann self-assigned this Jun 15, 2020
@kulmann kulmann merged commit 5d65689 into master Jun 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the upgrade-oC-sdk branch June 15, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having no settings values breaks the ui
2 participants