Fix breadcrumb last element #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @refs |
|
👏 if everyone is okay with this and it doesn't suppose an integrity problem with styles I'm cool with it |
Maybe there are tests related to it.. let's wait for drone. |
LukasHirt
approved these changes
Jul 1, 2020
|
Test failures 😅 looking into it after lunch... |
|
Was just an xpath selector issue. Didn't find the last breadcrumb segment anymore. That is fixed now (CI currently running). |
Since the last breadcrumb segment is not a link anymore, it is either an a-tag or a span-tag in the DOM. So we have to check for both possible types instead of just a-tags.
kulmann
force-pushed
the
fix-breadcrumb-last-element
branch
from
b1594a5
to
bfefd7e
Compare
Because of a recent change, breadcrumb segments can now be spans or anchors. Attempts to navigate by breadcrumb in tests should not happen on spans, only on anchors, to catch failures early. This commit fixes that.
Need to navigate to a subfolder to have the breadcrumb segment for a test clickable again.
kulmann
force-pushed
the
fix-breadcrumb-last-element
branch
from
1b53597
to
c0c2aa8
Compare
kulmann
force-pushed
the
fix-breadcrumb-last-element
branch
from
bc3efe7
to
3c44eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the anchor on the last breadcrumb segment.
Related Issue
Motivation and Context
Comply with common sense
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: