Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline around files list #3752

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Remove outline around files list #3752

merged 1 commit into from
Jul 8, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jul 8, 2020

Description

The files list was displaying an outline when it received focus after a click.
Since the focus is meant only programmatically, the outline was not supposed to be displayed.

Related Issue

How Has This Been Tested?

Click on a row in files list or in the header whitespace.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@@ -171,3 +171,9 @@ export default {
}
}
</script>

<style scoped>
.files-list-wrapper:focus {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is not an ODS component I am putting the styles in here on purpose.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 😍

@kulmann
Copy link
Member

kulmann commented Jul 8, 2020

Oh, why did you tick breaking change in the PR description? 🤔

@LukasHirt
Copy link
Collaborator Author

Oh, why did you tick breaking change in the PR description? 🤔

Damn, that's wrong 🤦 Thanks for spotting!

@LukasHirt LukasHirt merged commit 1034029 into master Jul 8, 2020
@LukasHirt LukasHirt deleted the bugfix/list-outline branch July 8, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not add border to filelist when clicking it File list has border on click
2 participants