[Tests-Only] Access last created public link with OCIS #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haribhandari07
force-pushed
the
accessPublicLink
branch
5 times, most recently
from
aaa3fa2
to
bfe940e
Compare
haribhandari07
force-pushed
the
accessPublicLink
branch
3 times, most recently
from
4ea357e
to
33d871f
Compare
dpakach
reviewed
Jul 22, 2020
| for (const share of shares) { | ||
| if (share.share_type === self.SHARE_TYPES.public_link && share.id >= lastFoundShareId) { | ||
| lastFoundShareId = share.id | ||
| if (share.share_type === self.SHARE_TYPES.public_link && share.stime > lastShareSTime) { |
There was a problem hiding this comment.
I think you need to update the lastShareSTime on the loop every time.
Otherwise it will always be 0
There was a problem hiding this comment.
I think you need to update the lastShareSTime on the loop every time.
Otherwise it will always be 0
Silly mistake
haribhandari07
force-pushed
the
accessPublicLink
branch
from
33d871f
to
52a86eb
Compare
individual-it
approved these changes
Jul 27, 2020
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run public link tests on ocis
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: