Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Run public share tests on ocis #3845

Merged
merged 1 commit into from
Aug 3, 2020
Merged

[Tests-Only] Run public share tests on ocis #3845

merged 1 commit into from
Aug 3, 2020

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Jul 28, 2020 •
edited
Loading

Description

This PR runs public share tests with ocis backend

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@haribhandari07 haribhandari07 force-pushed the runPublicShare branch 6 times, most recently from f5e4644 to 9a966d7 Compare July 30, 2020 08:39
@haribhandari07 haribhandari07 self-assigned this Jul 30, 2020
@haribhandari07 haribhandari07 added Status:Needs-Review Needs review from a maintainer QA:team labels Jul 30, 2020
@haribhandari07 haribhandari07 marked this pull request as ready for review July 30, 2020 10:03
kiranparajuli589
kiranparajuli589 reviewed Jul 31, 2020
View reviewed changes
tests/acceptance/stepDefinitions/publicLinkContext.js Outdated
@@ -83,6 +83,14 @@ Then('user {string} should not have any public link', async function(sharer) {
assert.strictEqual(resp.length, 0, 'User has shares. Response: ' + resp)
})

Then('user {string} should have some public shares', async function(sharer) {
const publicShares = await sharingHelper.getAllPublicLinkShares(sharer)
console.log(publicShares)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug line?

kiranparajuli589
kiranparajuli589 reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@individual-it individual-it merged commit e49958b into master Aug 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the runPublicShare branch August 3, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it approved these changes

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@haribhandari07 haribhandari07

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run public share phoenix tests on ocis
3 participants
@haribhandari07 @individual-it @kiranparajuli589