Rename "trash bin" to the "deleted files". #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
reviewed
Sep 15, 2020
LukasHirt
approved these changes
Sep 15, 2020
PVince81
force-pushed
the
wording-changes-trashbin
branch
from
71b12ae
to
0fb4a81
Compare
|
fixed the test, rebased and squashed |
|
missed one test 🤦 |
PVince81
force-pushed
the
wording-changes-trashbin
branch
from
0fb4a81
to
b04963a
Compare
|
okay, so that test is skipped on OC 10 that's why I didn't see it in my local run. fixed now |
|
some bad luck about time outs: https://drone.owncloud.com/owncloud/phoenix/11021/36/12 that test passed before... restarted... |
|
I also have the feeling that Drone is running slower. During the afternoon most test runs were able to finish in max 30+ minutes but now they take even longer. |
|
dependabot added or auto-rebased a bunch of PRs. drone got a queue of jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Part 5 of owncloud/product#231
Motivation and Context
How Has This Been Tested?
Manual test, visually
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: