Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ODS to v1.10.0 #4079

Closed
wants to merge 2 commits into from
Closed

Update ODS to v1.10.0 #4079

wants to merge 2 commits into from

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 16, 2020

Description

This PR updates ODS to v1.10.0 and makes use of new icons and a new prop for the sidebar.
AS v1.10.0 introduces breaking changes, this PR also brings in a lot of adjustments in the layout and use of buttons.

Related Issue

  • Fixes <issue_link>
    TODO: add links to product issues

Screenshots (if appropriate):

Accounts UI (not part of phoenix) has only one nav item at the moment. In the old ODS version this was hidden, now it's shown.

Screenshot 2020-09-16 at 13 58 45

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • fix button icons
  • check alignments of buttons (were inline before, are block elements now)

@update-docs
Copy link

update-docs bot commented Sep 16, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann
Copy link
Member Author

kulmann commented Sep 21, 2020

Superseded by #4086

@kulmann kulmann closed this Sep 21, 2020
@pascalwengerter pascalwengerter deleted the update-ods-1.10.0 branch April 28, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants