Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak roles selection dropdown #4080

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Tweak roles selection dropdown #4080

merged 1 commit into from
Sep 17, 2020

Conversation

PVince81
Copy link
Contributor

Description

Remove roles description text from the roles selection button, but keep it in the dropdown list.
Add chevron icon on the right.

Related Issue

Part 10 of owncloud/product#231

Motivation and Context

How Has This Been Tested?

Manual test

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@PVince81 PVince81 self-assigned this Sep 16, 2020
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong issue link in the changelog (see comment). the actual code is nice 🚀

changelog/unreleased/adjust-roles-selection-dropdown Outdated Show resolved Hide resolved
Remove roles description text from the roles selection button, but keep it in the dropdown list.
Add chevron icon on the right.
@PVince81
Copy link
Contributor Author

some unrelated timeout waiting for the "Rename" action... restarted

@PVince81
Copy link
Contributor Author

now random issue in upload... restarted

@PVince81 PVince81 merged commit e27b679 into master Sep 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the roles-dropdown-tweaks branch September 17, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants