Add tooltips in various places

apps/files/src/components/Collaborators/Collaborator.vue

@@ -11,6 +11,7 @@
             :id="$_resharerToggleId"
             variation="raw"
             :aria-label="$gettext('Show resharer details')"
+            :uk-tooltip="$gettext('Show resharer details')"
           >
             <span class="uk-flex uk-flex-middle">
               <oc-icon name="repeat" class="uk-preserve-width oc-icon-xsmall" />
@@ -61,6 +62,7 @@
         <oc-button
           v-if="$_deleteButtonVisible"
           :aria-label="$gettext('Delete share')"
+          :uk-tooltip="$gettext('Delete share')"
           variation="raw"
           class="files-collaborators-collaborator-delete"
           @click="$_removeShare"
@@ -140,6 +142,7 @@
         <oc-button
           v-if="$_editButtonVisible"
           :aria-label="$gettext('Edit share')"
+          :uk-tooltip="$gettext('Edit share')"
           variation="raw"
           class="files-collaborators-collaborator-edit"
           @click="$emit('onEdit', collaborator)"
@@ -157,7 +160,12 @@
             :aria-label="$gettext('Navigate to parent')"
             class="files-collaborators-collaborator-follow-via uk-flex uk-flex-middle"
           >
-            <oc-icon name="exit_to_app" size="small" class="uk-preserve-width" />
+            <oc-icon
+              name="exit_to_app"
+              size="small"
+              class="uk-preserve-width"
+              :uk-tooltip="$gettext('Navigate to parent')"
+            />
             <span
               class="oc-file-name uk-padding-remove uk-margin-xsmall-left uk-text-truncate files-collaborators-collaborator-via-label"
               >{{ $_viaLabel }}</span

apps/files/src/components/FileInfoVersions.vue

@@ -20,6 +20,7 @@
               <oc-button
                 variation="raw"
                 :aria-label="$gettext('Restore older version')"
+                :uk-tooltip="$gettext('Restore older version')"
                 @click="revertVersion(item)"
               >
                 <oc-icon name="restore" />
@@ -31,6 +32,7 @@
               <oc-button
                 variation="raw"
                 :aria-label="$gettext('Download older version')"
+                :uk-tooltip="$gettext('Download older version')"
                 @click="downloadVersion(item)"
               >
                 <oc-icon name="cloud_download" />

apps/files/src/components/FileLinkSidebar.vue

@@ -12,6 +12,7 @@
             <span v-translate>Private Link</span>
             <oc-button
               :aria-label="$_privateLinkCopyLabel"
+              :uk-tooltip="$_privateLinkCopyLabel"
               variation="raw"
               class="uk-margin-small-left"
             >

apps/files/src/components/FilesLists/Indicators.vue

@@ -8,6 +8,7 @@
           class="file-row-share-indicator uk-text-middle"
           :class="{ 'uk-margin-xsmall-left': index > 0, 'uk-invisible': !indicator.visible }"
           :aria-label="indicator.label"
+          :uk-tooltip="indicator.label"
           variation="raw"
           @click.native.stop="indicator.handler(item, indicator.id)"
         >
@@ -19,6 +20,8 @@
           v-for="(indicator, index) in defaultIndicators"
           :key="index"
           :name="indicator.icon"
+          :aria-label="indicator.label"
+          :uk-tooltip="indicator.label"
           class="uk-text-middle"
           size="small"
           variation="system"

apps/files/src/components/FilesLists/QuickActions.vue

@@ -4,7 +4,8 @@
       v-for="action in filteredActions"
       :id="`files-quick-action-${action.id}`"
       :key="action.label"
-      :aria-label="$gettext(action.label)"
+      :aria-label="action.label"
+      :uk-tooltip="action.label"
       variation="raw"
       class="uk-margin-xsmall-right"
       @click.native.stop="action.handler({ item, client: $client, store: $store })"

apps/files/src/components/PublicLinksSidebar/PublicLinkListItem.vue

@@ -5,6 +5,7 @@
         <oc-button
           v-if="$_deleteButtonVisible"
           :aria-label="$_deleteButtonLabel"
+          :uk-tooltip="$_deleteButtonLabel"
           variation="raw"
           class="oc-files-file-link-delete"
           @click="$_removeLink"
@@ -50,6 +51,7 @@
         <oc-button
           v-if="$_editButtonVisible"
           :aria-label="$_editButtonLabel"
+          :uk-tooltip="$_editButtonLabel"
           variation="raw"
           class="oc-files-file-link-edit"
           @click="$emit('onEdit', link)"
@@ -58,6 +60,7 @@
         </oc-button>
         <oc-button
           :aria-label="$_publicLinkCopyLabel"
+          :uk-tooltip="$_publicLinkCopyLabel"
           variation="raw"
           class="oc-files-file-link-copy-url"
         >

changelog/unreleased/add-missing-tooltips

@@ -0,0 +1,10 @@
+Bugfix: Added missing tooltips
+
+We've added tooltips for the following:
+
+- top bar: notifications button and application switcher
+- file list: share indicators and quick actions
+- sharing in sidebar: action icons like edit, delete, copy
+
+https://github.com/owncloud/phoenix/pull/4081
+https://github.com/owncloud/product/issues/231

src/components/ApplicationsMenu.vue

@@ -5,7 +5,8 @@
       ref="menubutton"
       variation="raw"
       class="oc-topbar-menu-burger"
-      :aria-label="$gettext('Application Switcher')"
+      :aria-label="applicationSwitcherLabel"
+      :uk-tooltip="applicationSwitcherLabel"
     >
       <oc-icon name="apps" aria-hidden="true" class="uk-flex" />
     </oc-button>
@@ -51,6 +52,10 @@ export default {
     }
   },
   computed: {
+    applicationSwitcherLabel() {
+      return this.$gettext('Application Switcher')
+    },
+
     $_applicationsList() {
       return this.applicationsList.map(item => {
         const lang = this.$language.current

src/components/Notifications.vue

@@ -4,7 +4,8 @@
       id="oc-notification-bell"
       class="oc-cursor-pointer uk-flex uk-flex-middle"
       name="bell"
-      aria-label="Notifications"
+      :aria-label="notificationsLabel"
+      :uk-tooltip="notificationsLabel"
     />
     <oc-drop
       id="oc-notification-drop"
@@ -49,7 +50,11 @@ import { mapGetters, mapActions } from 'vuex'
 
 export default {
   computed: {
-    ...mapGetters(['activeNotifications', 'configuration'])
+    ...mapGetters(['activeNotifications', 'configuration']),
+
+    notificationsLabel() {
+      return this.$gettext('Notifications')
+    }
   },
   methods: {
     ...mapActions(['deleteNotification', 'showMessage']),