Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember public link password on refresh #4083

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Sep 18, 2020

Description

Stores the public link password in sessionStorage so that it survives
page refresh. Closing the browser tab or to another tab doesn't preserve
it.

Related Issue

Part 8b of owncloud/product#231

Motivation and Context

How Has This Been Tested?

After entering password on public link page:

  • TEST: refresh the page doesn't ask for password again
  • TEST: closing page and opening the URL again asks for the URL again (so password is forgotten correctly)
  • TEST: change public link password to create a discrepancy with saved one: password is asked again

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

Stores the public link password in sessionStorage so that it survives
page refresh. Closing the browser tab or to another tab doesn't preserve
it.
@PVince81 PVince81 self-assigned this Sep 18, 2020
@PVince81
Copy link
Contributor Author

One little issue though is that the page blinks:

  1. When opening the public link, you first see the file list loading.
  2. Then the PROPFIND fails, it goes to the "public link password" vue.
  3. In that vue, it gets the saved password and shows "loading public link" spinner
  4. Then back to file list

Ideally we should already read the stored password earlier to avoid going to that "loading public link" page.
Maybe something for later ?

Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should already read the stored password earlier to avoid going to that "loading public link" page.
Maybe something for later ?

Do you think it would be simple to fix? If it would be something quick I'd vote for taking care of it already in this PR. Depending on how much disturbing is the jump between list and loading page. Do not want to block this PR though so taking care of it separately would be also fine for me

@PVince81
Copy link
Contributor Author

I have ideas for alternative approaches, I'll give them a try

@PVince81
Copy link
Contributor Author

alternative PR: #4084

@PVince81 PVince81 closed this Sep 18, 2020
@pascalwengerter pascalwengerter deleted the public-link-remember-password-on-refresh branch June 2, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants