Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve oc10 link #4092

Merged
merged 5 commits into from
Sep 21, 2020
Merged

Improve oc10 link #4092

merged 5 commits into from
Sep 21, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 21, 2020

Description

We have added an option to set the link target in external application links (defaults to _blank). The app switcher now shows all native extensions first and items based on application links last.

Related Issue

Motivation and Context

Make switch between classic and new frontend as easy as possible.

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2020-09-21 at 14 29 24

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit 4c4ca70 into master Sep 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the improve-oc10-link branch September 21, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate Switch between classic frontend and ocis-web
2 participants