[Tests-Only] Refactor webUISharingNotifications to use Shares folder #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haribhandari07
force-pushed
the
refactor-webUISharingNotifications
branch
from
7f1658b to
741544c
Compare
haribhandari07
commented
Sep 25, 2020
Comment on lines
16
to
21
| @skip @yetToImplement | ||
| Scenario: notification link redirection in case a share is pending | ||
| Given the setting "Automatically accept new incoming local user shares" in the section "Sharing" has been disabled | ||
| And user "user1" has shared folder "/simple-folder" with user "user2" | ||
| When the user follows the link of the first notification on the webUI | ||
| Then the user should be redirected to a webUI page with the title "Shared with you - %productname%" |
There was a problem hiding this comment.
@phil-davis I only copied the file/scenario from ...Root folder as this scenario is skipped and not implemented in Pheonix. What should I do here? Should I remove this or keep it as a reference to be implemented later?
haribhandari07
force-pushed
the
refactor-webUISharingNotifications
branch
from
741544c to
6733871
Compare
haribhandari07
force-pushed
the
refactor-webUISharingNotifications
branch
2 times, most recently
from
c15aa8c to
65278ad
Compare
individual-it
approved these changes
Oct 2, 2020
haribhandari07
force-pushed
the
refactor-webUISharingNotifications
branch
from
65278ad to
d1d4b99
Compare
delete-merged-branch
bot
deleted the
refactor-webUISharingNotifications
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
webUISharingNotificationsto use Root and Shares folder for shares.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: