Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] add tests demonstrating issue-product-203 in shareWithUsers scenarios #4209

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Oct 19, 2020

Description

  1. make sharing with user tests demonstrate and work despite file_target in share response product#203
  2. adjust one test, so it does not fail because of When a share exists its impossible to share a renamed folder ocis#719 (in that test the renaming is not essential to the test, and the test does not check the renaming)
  3. small improvement is error output

Related Issue

part of owncloud/ocis#518

Motivation and Context

  1. make tests work to avoid further regressions
  2. have tests that demonstrate the current behaviour

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it individual-it self-assigned this Oct 19, 2020
@phil-davis phil-davis changed the title add tests demonstrating issue-product-203 in shareWithUsers scenarios [tests-only] add tests demonstrating issue-product-203 in shareWithUsers scenarios Oct 19, 2020
@owncloud owncloud deleted a comment from update-docs bot Oct 19, 2020
@phil-davis phil-davis force-pushed the webUISharingInternalUsersIssue203Tests branch from 5b4517e to 9bc1d83 Compare October 19, 2020 12:32
@phil-davis
Copy link
Contributor

Rebased - let's see what CI thinks.

@individual-it
Copy link
Member Author

I've added an extra commit to avoid owncloud/ocis#719

@individual-it individual-it merged commit a8eb4b1 into master Oct 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the webUISharingInternalUsersIssue203Tests branch October 20, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants