Fix logout with OIDC #4211
Merged
Fix logout with OIDC #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
LukasHirt
force-pushed
the
bugfix/logout
branch
from
e5e8349
to
c714783
Compare
LukasHirt
force-pushed
the
bugfix/logout
branch
from
c714783
to
4e4096f
Compare
kulmann
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Looks good 👍 Just for the record: with this change we log out the user from the IdP. If it's a company wide IdP and we are just one application, this might be annoying. A better solution might be to unload the user and the user to click some "Login" button (without needing to enter credentials) when the user is still logged in at the IdP. CC @pmaier1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open signout URL directly.
Related Issue