[tests-only] fix loginAsUser #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
requested review from
phil-davis,
individual-it,
kulmann and
LukasHirt
C0rby
force-pushed
the
ui-tests-wait-for-thumbnails-fix
branch
2 times, most recently
from
8970ace
to
79268cb
Compare
|
This should also fix all remaining broken tests in https://drone.owncloud.com/owncloud/ocis/1342/. |
|
Ah damn it.. when there are no files it fails of course... |
C0rby
force-pushed
the
ui-tests-wait-for-thumbnails-fix
branch
from
79268cb
to
684676e
Compare
|
So now I fixed it more locally in loginAsUser. Let's see if this works. |
phil-davis
approved these changes
Nov 11, 2020
delete-merged-branch
bot
deleted the
ui-tests-wait-for-thumbnails-fix
branch
|
Note: this PR changed test code only, strictly-speaking a changelog was not required - but it does not hurt. |
|
Ah good to know for next time. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitForAllThumbnailsLoaded wasn't correctly waiting. It would return immediately if the files list was not loaded yet.loginAsUser wasn't correctly waiting for the files list. waitForAllThumbnailsLoaded returns immediately if the list or loader takes longer to appear.
Found here https://drone.owncloud.com/owncloud/ocis/1342/32/7
https://github.com/owncloud/phoenix/blob/572da6eeef637ce304cec5a366b9e423affb4772/tests/acceptance/helpers/loginHelper.js#L32