-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draw.io] Deployment config + .vsdx support #4337
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7af495d
Add support for .vsdx files
VirtualEvan 9da7c1b
Enable autosave
VirtualEvan a7c1505
Use the embed-specific diagrams.net app
VirtualEvan b9f3db1
Disable unsaved changes warning after saving
VirtualEvan a0ccf75
Set the right error message
VirtualEvan d1b6bbf
Add timestamp to the file name
VirtualEvan 1f7d376
Show message when importing a file
VirtualEvan 2f0e8e6
Use configurable settings for drawio
VirtualEvan 3671e2e
Do not load moment locales to reduce the bundle size
VirtualEvan 4c7e6d4
Add changelog
VirtualEvan 3748a0e
Use chromeless mode if the file is read only
VirtualEvan 5c9d455
Get config from the right place: #4380
VirtualEvan 8bc0e3b
Load the application after checking the file permissions
VirtualEvan b95c278
Add config samples
VirtualEvan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,53 @@ | ||
const VueLoaderPlugin = require('vue-loader/lib/plugin') | ||
const webpack = require('webpack') | ||
|
||
module.exports = { | ||
plugins: [ | ||
new VueLoaderPlugin() | ||
], | ||
plugins: [new VueLoaderPlugin(), new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/)], | ||
entry: { | ||
'draw-io': [ | ||
'core-js/modules/es6.promise', | ||
'core-js/modules/es6.array.iterator', | ||
'./src/app.js' | ||
] | ||
'draw-io': ['core-js/modules/es6.promise', 'core-js/modules/es6.array.iterator', './src/app.js'] | ||
}, | ||
output: { | ||
publicPath: 'apps/draw-io/', | ||
chunkFilename: '[name].draw-io.chunk.js', | ||
filename: 'draw-io.bundle.js' | ||
}, | ||
module: { | ||
rules: [{ | ||
test: /\.js?$/, | ||
exclude: /node_modules/, | ||
loader: 'babel-loader', | ||
options: { | ||
rootMode: 'upward' | ||
} | ||
}, { | ||
test: /\.vue$/, | ||
loader: 'vue-loader' | ||
}, | ||
{ | ||
test: /\.jsx?$/, | ||
include: /node_modules\/(?=(query-string|split-on-first|strict-uri-encode)\/).*/, | ||
use: { | ||
rules: [ | ||
{ | ||
test: /\.js?$/, | ||
exclude: /node_modules/, | ||
loader: 'babel-loader', | ||
options: { | ||
presets: [ | ||
[ | ||
'@babel/preset-env', | ||
{ | ||
targets: { | ||
ie: '11' | ||
rootMode: 'upward' | ||
} | ||
}, | ||
{ | ||
test: /\.vue$/, | ||
loader: 'vue-loader' | ||
}, | ||
{ | ||
test: /\.jsx?$/, | ||
include: /node_modules\/(?=(query-string|split-on-first|strict-uri-encode)\/).*/, | ||
use: { | ||
loader: 'babel-loader', | ||
options: { | ||
presets: [ | ||
[ | ||
'@babel/preset-env', | ||
{ | ||
targets: { | ||
ie: '11' | ||
} | ||
} | ||
} | ||
] | ||
] | ||
] | ||
} | ||
} | ||
}, | ||
{ | ||
test: /\.css$/, | ||
use: ['vue-style-loader', 'css-loader'] | ||
} | ||
}, | ||
{ | ||
test: /\.css$/, | ||
use: [ | ||
'vue-style-loader', | ||
'css-loader' | ||
] | ||
}] | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Enhancement: Add custom configuration to the draw.io app | ||
|
||
Added mechanism to specify custom configuration instead of using a hardcoded | ||
one. The new settings include support for a custom draw.io server, enabling | ||
autosave and using a specific theme. | ||
|
||
https://github.com/owncloud/phoenix/pull/4337 | ||
https://github.com/owncloud/phoenix/issues/4328 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Enhancement: Add support for .vsdx files in the draw.io app | ||
|
||
Added the support to open .vsdx files (Microsoft Visio Files) directly | ||
from OwnCloud, instead of creating a new diagram to import the file from | ||
local storage. | ||
|
||
https://github.com/owncloud/phoenix/pull/4337 | ||
https://github.com/owncloud/phoenix/issues/4327 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this method work here? https://github.com/owncloud/owncloud-sdk/blob/c4b96e0b50bf989e792899913fe3a70fd1698b43/src/fileManagement.js#L76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried with
getFileContent
, but it looks like we cannot specify the responsetype. Drawio is able to handle the vsdx file as base64, so we need the file itself insted of its content. Also tried to re-create the file from its binary content, but I could not find a way to do so, the resultant file was always different.