Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme redirect page #4373

Merged
merged 1 commit into from
Nov 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/theme-redirect
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Theme redirect and access denied pages

We've adjusted the theme on OIDC redirect and access denied pages to use correct logo and background.
We've also added those two values into the theming capabilities.

https://github.com/owncloud/phoenix/pull/4373
6 changes: 6 additions & 0 deletions changelog/unreleased/update-ods
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Update ODS to 2.0.0

We've updated the ownCloud design system to version 2.0.0.

https://github.com/owncloud/owncloud-design-system/releases/tag/v2.0.0
https://github.com/owncloud/phoenix/pull/4373
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"node-fs-extra": "^0.8.2",
"npm-run-all": "^4.1.5",
"oidc-client": "^1.9.1",
"owncloud-design-system": "^1.15.0",
"owncloud-design-system": "^2.0.0",
"owncloud-sdk": "^1.0.0-740",
"p-limit": "^2.2.1",
"p-queue": "^6.1.1",
Expand Down
18 changes: 14 additions & 4 deletions src/pages/accessDenied.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<template>
<div class="oc-login" uk-height-viewport>
<div
class="oc-login"
uk-height-viewport
:style="{ backgroundImage: 'url(' + backgroundImg + ')' }"
>
<div class="oc-login-card uk-position-center">
<h1 v-translate class="oc-login-logo">
ownCloud
</h1>
<img class="oc-login-logo" :src="logoImg" :alt="configuration.theme.general.name" />
<div class="oc-login-card-body uk-width-large">
<h3 class="oc-login-card-title">
<span v-translate>Login Error</span>
Expand Down Expand Up @@ -62,6 +64,14 @@ export default {
return this.configuration.theme.general.helpDeskLinkText
}
return ''
},

logoImg() {
return this.configuration.theme.logo.login
},

backgroundImg() {
return this.configuration.theme.loginPage.backgroundImg
}
},
methods: {
Expand Down
22 changes: 17 additions & 5 deletions src/pages/oidcCallback.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<template>
<div class="oc-login" uk-height-viewport>
<div
class="oc-login"
:style="{ backgroundImage: 'url(' + backgroundImg + ')' }"
uk-height-viewport
>
<div class="oc-login-card uk-position-center">
<h1 v-translate class="oc-login-logo">
ownCloud
</h1>
<img class="oc-login-logo" :src="logoImg" :alt="configuration.theme.general.name" />
<div v-show="error" class="oc-login-card-body">
<h3 class="oc-login-card-title">
<translate>Authentication failed</translate>
Expand Down Expand Up @@ -38,9 +40,19 @@ export default {
error: false
}
},
computed: {
...mapGetters(['configuration'])
...mapGetters(['configuration']),
backgroundImg() {
return this.configuration.theme.loginPage.backgroundImg
},
logoImg() {
return this.configuration.theme.logo.login
}
},
mounted() {
this.$nextTick(() => {
if (this.$route.query.error) {
Expand Down
6 changes: 4 additions & 2 deletions src/store/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@ const state = {
},
logo: {
sidebar: '',
favicon: ''
favicon: '',
login: ''
},
filesList: {
hideDefaultStatusIndicators: false
},
loginPage: {
autoRedirect: true
autoRedirect: true,
backgroundImg: ''
}
},
options: {
Expand Down
6 changes: 4 additions & 2 deletions themes/owncloud.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
},
"logo": {
"sidebar": "themes/owncloud/assets/logo.svg",
"favicon": "themes/owncloud/favicon.jpg"
"favicon": "themes/owncloud/favicon.jpg",
"login": "themes/owncloud/assets/logo.svg"
},
"filesList": {
"hideDefaultStatusIndicators": false
},
"loginPage": {
"autoRedirect": true
"autoRedirect": true,
"backgroundImg": "themes/owncloud/assets/loginBackground.jpg"
}
}
Binary file added themes/owncloud/assets/loginBackground.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6907,10 +6907,10 @@ os-tmpdir@~1.0.1, os-tmpdir@~1.0.2:
resolved "https://registry.yarnpkg.com/os-tmpdir/-/os-tmpdir-1.0.2.tgz#bbe67406c79aa85c5cfec766fe5734555dfa1274"
integrity sha1-u+Z0BseaqFxc/sdm/lc0VV36EnQ=

owncloud-design-system@^1.15.0:
version "1.15.0"
resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-1.15.0.tgz#202687b4c246db616d467b3eb1af09cd65775a51"
integrity sha512-vdSgA2UKHf9T1aoIr+t8x2Apz1RKeql5TKuozX/kMgaviNVlLyKspRTi+PD/tF830uTk+qIjRmDLuq5qdQXrng==
owncloud-design-system@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-2.0.0.tgz#dcb31743e900dffefdf02f1872717b122752baa0"
integrity sha512-yVP2y9G4aQ6H1LRNqDZByfZkuGuQKcwFzDMIDeRbAXXBNfnipZ5TI3Jprix4uixiny0bH87kX4i7/aH1VDR1BQ==
dependencies:
luxon "^1.22.0"
mini-css-extract-plugin "^0.9.0"
Expand Down