Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public link fixes #4425

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Public link fixes #4425

merged 2 commits into from
Dec 5, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Dec 5, 2020 •
edited
Loading

Description

This PR fixes some public link issues.

  • batch actions were not available for public links
  • creating a folder in a public link context showed an error
  • quick actions for sharing are not available in public links (by design) but showed an error on the capabilities check.

Related Issue

Motivation and Context

Hardening

How Has This Been Tested?

  • drone

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann
Fix public link issues
533a01d 
- batch actions were not available for public links
- creating a folder in a public link context showed an error
- quick actions for sharing are not available in public links (by
design) but showed an error on the capabilities check.
@kulmann
Changelog
7dc8e2d
@kulmann kulmann changed the title Fix public create folder Public link fixes Dec 5, 2020
@kulmann kulmann self-assigned this Dec 5, 2020
@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Dec 5, 2020
@phil-davis phil-davis mentioned this pull request Dec 5, 2020
Closed
@phil-davis
Copy link
Contributor

I was a bit surprised that no UI tests needed to be touched by this PR. That means that there are not relevant UI tests currently, or they are there but skipped. I raised issue #4426 to get that sorted out. We do not need to delay this PR.

@kulmann
Copy link
Member Author

kulmann commented Dec 5, 2020

Thanks for taking care @phil-davis !

LukasHirt
LukasHirt approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@kulmann kulmann merged commit 222074b into master Dec 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-public-create-folder branch December 5, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create folder in public link shows an error
3 participants
@kulmann @phil-davis @LukasHirt