Fix burger menu button #4572
Merged
Fix burger menu button #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
fix-burger-menu-button
branch
from
8d7c30e
to
60b1286
Compare
kulmann
commented
Dec 30, 2020
| gutter="small" | ||
| class="uk-width-expand uk-flex-right oc-mt-rm" | ||
| > | ||
| <oc-grid v-if="!isPublicPage" flex gutter="small" class="uk-width-expand uk-flex-right oc-m-rm"> |
There was a problem hiding this comment.
Hint for reviewers: the only change here is that we don't use the utility class for removing the top margin (oc-mt-rm) anymore, but instead the utility class for removing all margins (oc-m-rm). The oc-grid is introducing a negative left margin (-15px) which is pulling parts of the topbar on top of the button. Removing the (unneeded) margins fixes that.
butonic
approved these changes
Dec 30, 2020
|
Restarted CI because of random 502 bad gateway on yarnpkg.com: |
LukasHirt
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The button for hiding/showing the left sidebar (burger menu) was not fully clickable. We fixed this by removing a negative margin that pulled the rest of the topbar over the button.
This bug was only taking effect when the search input field is hidden. This is why this was only a known bug in oCIS, not with oc10 backend (because we typically keep the search input when running with oc10).
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: