Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ODS to 2.1.2 #4594

Merged
merged 11 commits into from
Feb 2, 2021
Merged

Update ODS to 2.1.2 #4594

merged 11 commits into from
Feb 2, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jan 8, 2021 •
edited
Loading

Description

This PR updates ODS to 2.1.2
We needed to do some fixes because of changed things in ODS:

  • oc-table is now oc-table-simple
  • oc-star doesn't exist anymore
  • moment has been removed from ODS. We want to use luxon now instead - replacing first occurrence of moment in this PR (because it was used from ODS, which doesn't provide moment anymore), others will follow in a separate one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs

This comment has been minimized.

Sign in to view
@kulmann kulmann self-assigned this Jan 8, 2021
@kulmann kulmann requested a review from LukasHirt January 8, 2021 11:37
@kulmann kulmann force-pushed the ods-table-component branch 2 times, most recently from 4b980fb to fdaefc0 Compare January 19, 2021 13:42
@kulmann kulmann changed the title use oc-table-simple instead of oc-table Update ODS to 2.1.0 Jan 19, 2021
@kulmann kulmann force-pushed the ods-table-component branch 2 times, most recently from 36258ed to 34a2d13 Compare January 27, 2021 12:43
@kulmann
Copy link
Member Author

kulmann commented Jan 29, 2021

Rebased after #4671 got merged

@kulmann kulmann marked this pull request as ready for review January 29, 2021 17:55
@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Jan 30, 2021
@kulmann
Copy link
Member Author

kulmann commented Jan 30, 2021

Finally green CI. Please re-review @LukasHirt 😃

@kulmann kulmann changed the title Update ODS to 2.1.0 Update ODS to 2.1.2 Feb 2, 2021
LukasHirt
LukasHirt approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kulmann kulmann merged commit fbdeaa5 into master Feb 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the ods-table-component branch February 2, 2021 10:25
@micbar micbar mentioned this pull request Feb 17, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @LukasHirt