Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set NODE_ENV based on rollup build type #4820

Merged
merged 1 commit into from
Mar 17, 2021
Merged

set NODE_ENV based on rollup build type #4820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/fix-node-env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: NODE_ENV based on rollup mode

The NODE_ENV was set to production by default, now we use development if rollup is started in watch mode so that the vue devtools can be used.

https://github.com/owncloud/web/issues/4819
https://github.com/owncloud/web/pull/4820
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const plugins = [
exclude: 'node_modules/**'
}),
modify({
'process.env.NODE_ENV': JSON.stringify('production'),
'process.env.NODE_ENV': JSON.stringify(production ? 'production' : 'development'),
// todo: remove after pending PR is merged
// fix for 'assignment to undeclared variable dav' in davclient.js/lib/client.js 6:0
"if (typeof dav === 'undefined') { dav = {}; }": 'var dav = dav || {}',
Expand Down