Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing translations in ApplicationsMenu Component #4830

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Fix missing translations in ApplicationsMenu Component #4830

merged 1 commit into from
Mar 19, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 19, 2021 •
edited
Loading

Description

Application names in the application switcher has not been translated, but will now.

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear AlexAndBear self-assigned this Mar 19, 2021
@owncloud owncloud deleted a comment from update-docs bot Mar 19, 2021
@AlexAndBear AlexAndBear force-pushed the fix-missing-translations-in-applications-menu branch from 13c3d14 to 03aa6af Compare March 19, 2021 10:32
kulmann
kulmann approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@AlexAndBear AlexAndBear merged commit 72f88ff into master Mar 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-missing-translations-in-applications-menu branch March 19, 2021 12:56
@fschade fschade mentioned this pull request Mar 30, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @kulmann