Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility on user menu #5010

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Improve accessibility on user menu #5010

merged 4 commits into from
Apr 26, 2021

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Apr 23, 2021 •
edited
Loading

Description

Wrapped the user menu button in a nav element and added an aria-label which describes it as main navigation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen added Status:Needs-Review Needs review from a maintainer Topic:Accessibility labels Apr 23, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests Upload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15087/

20210426-072435-537.png
20210426-072449-952.png

pascalwengerter
pascalwengerter approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦆

@kulmann kulmann changed the base branch from master to a11y-swarming April 26, 2021 08:56
@kulmann kulmann merged commit 222e1fe into a11y-swarming Apr 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the profile-dropdown-nav branch April 26, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
Status:Needs-Review Needs review from a maintainer Topic:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JammingBen @ownclouders @kulmann @pascalwengerter @Talank @individual-it