Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add focus trap to left sidebar #5027

Merged
merged 5 commits into from
May 7, 2021
Merged

feat: add focus trap to left sidebar #5027

merged 5 commits into from
May 7, 2021

Conversation

LukasHirt
Copy link
Collaborator

Description

We've added a focus trap to the left sidebar on smaller resolutions when it's collapsible.
If the sidebar is opened and focus, the focus stays within the sidebar.

How Has This Been Tested?

  • test environment: Chrome
  • test case 1: Open sidebar and focus nav
  • test case 2: Open sidebar after it has been closed and focus nav
  • test case 3: Expand screen width over 1200px and try to focus in and out of sidebar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Apr 27, 2021
@LukasHirt LukasHirt self-assigned this Apr 27, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15140/

20210427-090942-862.png
20210427-091112-171.png
20210427-091213-319.png
20210427-091250-461.png
20210427-091332-153.png
20210427-091449-992.png
20210427-091502-876.png

pascalwengerter
pascalwengerter requested changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work in Firefox (stuck at the close button) and Safari (not at all) though

changelog/unreleased/enhancement-sidebar-focus-trap Outdated Show resolved Hide resolved
@LukasHirt
Copy link
Collaborator Author

Doesn't work in Firefox (stuck at the close button) and Safari (not at all) though

Both are issues already on master and not due to the focus trap - I would see this is a different PR to keep the concerns separated.

@LukasHirt
Copy link
Collaborator Author

Also, pls note that this PR doesn't bring any focus management regarding focusing the first element in the sidebar when opened...

@pascalwengerter
Copy link
Contributor

Doesn't work in Firefox (stuck at the close button) and Safari (not at all) though

Both are issues already on master and not due to the focus trap - I would see this is a different PR to keep the concerns separated.

Agreed. We should also update the nav to collapse on route change on mobile, not sure if this has been documented somewhere already :)

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15142/

20210427-094938-636.png
20210427-095114-119.png
20210427-095219-839.png
20210427-095257-235.png
20210427-095344-211.png
20210427-095506-959.png
20210427-095520-868.png

@LukasHirt LukasHirt force-pushed the feat/left-sidebar-focus-trap branch from a76d6fb to 25225b1 Compare April 27, 2021 10:47
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15148/

20210427-105813-339.png
20210427-105904-179.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15148/

20210427-105639-051.png
20210427-105815-810.png
20210427-105920-682.png
20210427-105958-057.png
20210427-110043-263.png
20210427-110206-927.png
20210427-110221-214.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15148/

20210427-105909-429.png
20210427-110118-636.png
20210427-110131-992.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15148/

20210427-110243-292.png
20210427-110335-814.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15148/

20210427-105822-768.png
20210427-105853-975.png
20210427-110033-732.png
20210427-110106-833.png
20210427-110140-165.png
20210427-110213-288.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15148/

20210427-110257-251.png
20210427-110352-297.png
20210427-111116-947.png
20210427-111208-940.png

@LukasHirt LukasHirt force-pushed the feat/left-sidebar-focus-trap branch from 25225b1 to 0f17279 Compare May 4, 2021 11:47
@LukasHirt
Copy link
Collaborator Author

@kulmann focus trap activated only when the sidebar is an overlay now... It's still a bit useless though because of the missing focus trigger as mentioned here #5027 (comment) not sure yet how to handle this though as all the content is hidden inside the component 🤷

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15284/

20210504-115408-314.png
20210504-115437-928.png
20210504-115507-475.png
20210504-115537-570.png
20210504-115608-098.png
20210504-115638-963.png
20210504-115709-983.png
20210504-115739-369.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15284/

20210504-115500-213.png
20210504-115532-824.png
20210504-115604-503.png
20210504-115636-439.png
20210504-115708-146.png
20210504-115739-809.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15284/

20210504-115549-461.png
20210504-115619-398.png
20210504-115648-477.png
20210504-115717-703.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15284/

20210504-115526-887.png
20210504-115552-751.png
20210504-115619-455.png
20210504-115647-669.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15284/

20210504-115500-511.png
20210504-115531-840.png
20210504-115602-832.png
20210504-115633-619.png
20210504-115814-177.png
20210504-115848-634.png
20210504-115922-341.png
20210504-115957-870.png
20210504-120050-022.png
20210504-120124-666.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15284/

20210504-115703-607.png
20210504-115753-067.png
20210504-120032-357.png
20210504-120103-442.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15284/

20210504-115708-806.png
20210504-115742-010.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121558-425.png
20210507-121623-264.png
20210507-121647-993.png
20210507-121712-667.png
20210507-121737-328.png
20210507-121801-829.png
20210507-121826-237.png
20210507-121850-955.png
20210507-121915-574.png
20210507-121940-058.png
20210507-122004-573.png
20210507-122028-904.png
20210507-122053-206.png
20210507-122117-599.png
20210507-122142-036.png
20210507-122206-322.png
20210507-122230-709.png
20210507-122255-007.png
20210507-122319-434.png
20210507-122343-804.png
20210507-122408-136.png
20210507-122432-364.png
20210507-122456-734.png
20210507-122521-098.png
20210507-122545-447.png
20210507-122609-649.png
20210507-122633-908.png
20210507-122658-024.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121558-302.png
20210507-121623-412.png
20210507-121648-315.png
20210507-121712-791.png
20210507-121737-140.png
20210507-121801-443.png
20210507-121825-868.png
20210507-121850-195.png
20210507-121914-590.png
20210507-121938-975.png
20210507-122003-304.png
20210507-122028-033.png
20210507-122052-795.png
20210507-122117-196.png
20210507-122141-535.png
20210507-122205-820.png
20210507-122230-061.png
20210507-122254-229.png
20210507-122318-477.png
20210507-122342-673.png
20210507-122406-890.png
20210507-122431-045.png
20210507-122455-266.png
20210507-122519-420.png
20210507-122543-623.png
20210507-122607-904.png
20210507-122632-016.png
20210507-122656-340.png
20210507-122720-520.png
20210507-122744-717.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121540-638.png
20210507-121605-214.png
20210507-121629-877.png
20210507-121654-216.png
20210507-121718-686.png
20210507-121743-123.png
20210507-121807-660.png
20210507-121832-350.png
20210507-121856-841.png
20210507-121921-559.png
20210507-121945-580.png
20210507-122009-967.png
20210507-122034-485.png
20210507-122058-834.png
20210507-122123-068.png
20210507-122147-634.png
20210507-122212-389.png
20210507-122236-824.png
20210507-122301-366.png
20210507-122325-560.png
20210507-122349-804.png
20210507-122414-187.png
20210507-122438-426.png
20210507-122502-602.png
20210507-122526-741.png
20210507-122550-874.png
20210507-122615-042.png
20210507-122639-173.png
20210507-122703-434.png
20210507-122727-419.png
20210507-122751-584.png
20210507-122815-742.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersExpireToRoot failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121549-737.png
20210507-121614-352.png
20210507-121639-470.png
20210507-121705-647.png
20210507-121731-498.png
20210507-121756-112.png
20210507-121822-295.png
20210507-121850-192.png
20210507-121918-145.png
20210507-121946-461.png
20210507-122014-367.png
20210507-122042-157.png
20210507-122110-086.png
20210507-122138-270.png
20210507-122206-401.png
20210507-122234-316.png
20210507-122302-063.png
20210507-122329-968.png
20210507-122357-713.png
20210507-122425-303.png
20210507-122454-613.png
20210507-122525-732.png
20210507-122556-487.png
20210507-122627-212.png
20210507-122658-412.png
20210507-122729-774.png
20210507-122801-427.png
20210507-122832-872.png
20210507-122902-423.png
20210507-122930-249.png
20210507-122958-082.png
20210507-123025-705.png
20210507-123053-316.png
20210507-123120-895.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121529-779.png
20210507-121557-354.png
20210507-121625-021.png
20210507-121652-632.png
20210507-121720-163.png
20210507-121747-785.png
20210507-121815-590.png
20210507-121843-567.png
20210507-121911-090.png
20210507-121938-322.png
20210507-122005-439.png
20210507-122032-656.png
20210507-122100-155.png
20210507-122127-704.png
20210507-122156-660.png
20210507-122226-310.png
20210507-122257-537.png
20210507-122328-254.png
20210507-122358-531.png
20210507-122428-878.png
20210507-122455-895.png
20210507-122522-828.png
20210507-122550-777.png
20210507-122618-744.png
20210507-122646-756.png
20210507-122715-857.png
20210507-122745-692.png
20210507-122815-912.png
20210507-122846-253.png
20210507-122916-603.png
20210507-122947-684.png
20210507-123018-789.png
20210507-123049-965.png
20210507-123121-201.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121545-800.png
20210507-121611-921.png
20210507-121637-965.png
20210507-121704-113.png
20210507-121730-194.png
20210507-121756-147.png
20210507-121821-207.png
20210507-121845-985.png
20210507-121910-829.png
20210507-121936-021.png
20210507-122000-962.png
20210507-122025-822.png
20210507-122050-531.png
20210507-122115-167.png
20210507-122139-644.png
20210507-122204-121.png
20210507-122230-038.png
20210507-122255-887.png
20210507-122320-583.png
20210507-122345-211.png
20210507-122411-750.png
20210507-122438-148.png
20210507-122505-700.png
20210507-122533-346.png
20210507-122600-792.png
20210507-122628-311.png
20210507-122653-340.png
20210507-122718-946.png
20210507-122744-591.png
20210507-122810-255.png
20210507-122835-752.png
20210507-122901-408.png
20210507-122926-521.png
20210507-122951-017.png
20210507-123015-523.png
20210507-123040-049.png
20210507-123104-381.png
20210507-123128-751.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121535-767.png
20210507-121601-001.png
20210507-121626-702.png
20210507-121652-315.png
20210507-121717-882.png
20210507-121743-429.png
20210507-121809-030.png
20210507-121834-711.png
20210507-121859-873.png
20210507-121924-809.png
20210507-121950-458.png
20210507-122015-955.png
20210507-122041-228.png
20210507-122106-403.png
20210507-122131-638.png
20210507-122156-719.png
20210507-122222-233.png
20210507-122247-684.png
20210507-122314-473.png
20210507-122341-726.png
20210507-122408-998.png
20210507-122435-761.png
20210507-122502-298.png
20210507-122528-812.png
20210507-122553-799.png
20210507-122618-708.png
20210507-122643-856.png
20210507-122708-991.png
20210507-122734-976.png
20210507-122801-937.png
20210507-122829-439.png
20210507-122857-478.png
20210507-122925-435.png
20210507-122953-354.png
20210507-123021-449.png
20210507-123049-564.png
20210507-123117-682.png
20210507-123145-797.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersExpire failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121537-435.png
20210507-121604-025.png
20210507-121631-115.png
20210507-121659-014.png
20210507-121727-180.png
20210507-121754-193.png
20210507-121822-146.png
20210507-121851-674.png
20210507-121921-390.png
20210507-121951-304.png
20210507-122021-132.png
20210507-122050-827.png
20210507-122120-681.png
20210507-122150-551.png
20210507-122220-449.png
20210507-122250-338.png
20210507-122320-086.png
20210507-122349-887.png
20210507-122419-515.png
20210507-122449-379.png
20210507-122520-945.png
20210507-122553-259.png
20210507-122625-845.png
20210507-122658-393.png
20210507-122731-461.png
20210507-122804-842.png
20210507-122837-885.png
20210507-122910-999.png
20210507-122942-336.png
20210507-123011-697.png
20210507-123041-094.png
20210507-123110-327.png
20210507-123139-861.png
20210507-123209-093.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Upload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121537-632.png
20210507-121602-781.png
20210507-121627-918.png
20210507-121652-884.png
20210507-121717-879.png
20210507-121743-118.png
20210507-121808-351.png
20210507-121833-612.png
20210507-121858-634.png
20210507-121922-912.png
20210507-121947-024.png
20210507-122011-708.png
20210507-122036-092.png
20210507-122100-380.png
20210507-122125-305.png
20210507-122150-340.png
20210507-122215-154.png
20210507-122240-157.png
20210507-122305-259.png
20210507-122329-838.png
20210507-122355-109.png
20210507-122420-016.png
20210507-122445-263.png
20210507-122510-469.png
20210507-122534-994.png
20210507-122559-322.png
20210507-122623-777.png
20210507-122648-185.png
20210507-122712-414.png
20210507-122736-860.png
20210507-122801-284.png
20210507-122825-708.png
20210507-122850-125.png
20210507-122914-543.png
20210507-122938-827.png
20210507-123003-344.png
20210507-123027-715.png
20210507-123052-176.png
20210507-123116-581.png
20210507-123140-832.png
20210507-123205-302.png
20210507-123229-823.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121540-090.png
20210507-121604-916.png
20210507-121629-765.png
20210507-121654-693.png
20210507-121719-538.png
20210507-121744-165.png
20210507-121808-710.png
20210507-121833-958.png
20210507-121859-315.png
20210507-121924-126.png
20210507-121948-894.png
20210507-122013-708.png
20210507-122038-356.png
20210507-122103-117.png
20210507-122128-746.png
20210507-122154-278.png
20210507-122220-937.png
20210507-122247-415.png
20210507-122312-162.png
20210507-122336-925.png
20210507-122401-678.png
20210507-122426-356.png
20210507-122454-500.png
20210507-122523-622.png
20210507-122549-421.png
20210507-122613-972.png
20210507-122638-890.png
20210507-122703-671.png
20210507-122728-436.png
20210507-122753-334.png
20210507-122818-004.png
20210507-122842-680.png
20210507-122907-155.png
20210507-122931-629.png
20210507-122956-166.png
20210507-123020-770.png
20210507-123045-209.png
20210507-123109-725.png
20210507-123135-991.png
20210507-123202-241.png
20210507-123226-854.png
20210507-123251-254.png
20210507-123315-836.png
20210507-123340-469.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121552-714.png
20210507-121620-711.png
20210507-121648-480.png
20210507-121716-015.png
20210507-121743-596.png
20210507-121811-678.png
20210507-121839-108.png
20210507-121907-416.png
20210507-121934-671.png
20210507-122002-358.png
20210507-122029-707.png
20210507-122057-057.png
20210507-122124-662.png
20210507-122151-997.png
20210507-122219-420.png
20210507-122246-522.png
20210507-122313-963.png
20210507-122341-515.png
20210507-122409-826.png
20210507-122438-148.png
20210507-122506-324.png
20210507-122534-182.png
20210507-122602-352.png
20210507-122630-550.png
20210507-122658-286.png
20210507-122725-836.png
20210507-122753-311.png
20210507-122820-905.png
20210507-122848-039.png
20210507-122915-231.png
20210507-122943-282.png
20210507-123011-201.png
20210507-123041-609.png
20210507-123112-066.png
20210507-123141-623.png
20210507-123210-951.png
20210507-123241-368.png
20210507-123311-388.png
20210507-123341-955.png
20210507-123412-001.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUICreate failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121546-360.png
20210507-121611-030.png
20210507-121635-853.png
20210507-121700-396.png
20210507-121724-935.png
20210507-121749-868.png
20210507-121814-503.png
20210507-121839-172.png
20210507-121903-482.png
20210507-121926-486.png
20210507-121950-608.png
20210507-122015-049.png
20210507-122039-506.png
20210507-122103-986.png
20210507-122128-473.png
20210507-122152-819.png
20210507-122217-155.png
20210507-122241-422.png
20210507-122305-842.png
20210507-122330-223.png
20210507-122354-638.png
20210507-122418-816.png
20210507-122443-131.png
20210507-122507-439.png
20210507-122531-791.png
20210507-122556-091.png
20210507-122620-290.png
20210507-122644-597.png
20210507-122708-846.png
20210507-122733-247.png
20210507-122757-478.png
20210507-122821-891.png
20210507-122846-240.png
20210507-122910-550.png
20210507-122934-699.png
20210507-122959-023.png
20210507-123023-207.png
20210507-123047-399.png
20210507-123111-508.png
20210507-123135-649.png
20210507-123159-730.png
20210507-123223-728.png
20210507-123247-794.png
20210507-123311-978.png
20210507-123336-088.png
20210507-123400-090.png
20210507-123424-040.png
20210507-123448-137.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121558-574.png
20210507-121627-223.png
20210507-121655-894.png
20210507-121724-123.png
20210507-121752-890.png
20210507-121821-409.png
20210507-121849-951.png
20210507-121918-583.png
20210507-121947-340.png
20210507-122016-533.png
20210507-122045-930.png
20210507-122115-449.png
20210507-122144-350.png
20210507-122212-618.png
20210507-122240-705.png
20210507-122308-878.png
20210507-122337-530.png
20210507-122406-692.png
20210507-122435-832.png
20210507-122504-972.png
20210507-122535-141.png
20210507-122605-574.png
20210507-122635-540.png
20210507-122705-753.png
20210507-122735-668.png
20210507-122805-753.png
20210507-122835-699.png
20210507-122905-987.png
20210507-122935-780.png
20210507-123005-644.png
20210507-123035-381.png
20210507-123105-111.png
20210507-123134-955.png
20210507-123204-681.png
20210507-123233-637.png
20210507-123302-540.png
20210507-123331-454.png
20210507-123400-639.png
20210507-123429-534.png
20210507-123458-453.png
20210507-123527-414.png
20210507-123556-315.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121542-516.png
20210507-121607-812.png
20210507-121632-622.png
20210507-121657-347.png
20210507-121722-148.png
20210507-121747-096.png
20210507-121815-177.png
20210507-121842-719.png
20210507-121910-515.png
20210507-121936-857.png
20210507-122004-214.png
20210507-122030-907.png
20210507-122100-920.png
20210507-122131-421.png
20210507-122158-073.png
20210507-122224-437.png
20210507-122249-011.png
20210507-122313-660.png
20210507-122338-800.png
20210507-122403-728.png
20210507-122428-787.png
20210507-122453-660.png
20210507-122520-257.png
20210507-122547-250.png
20210507-122612-849.png
20210507-122637-807.png
20210507-122702-783.png
20210507-122727-525.png
20210507-122752-713.png
20210507-122817-753.png
20210507-122844-235.png
20210507-122910-572.png
20210507-122936-915.png
20210507-123003-211.png
20210507-123027-889.png
20210507-123052-658.png
20210507-123117-610.png
20210507-123142-621.png
20210507-123207-493.png
20210507-123232-391.png
20210507-123257-471.png
20210507-123322-570.png
20210507-123347-632.png
20210507-123412-583.png
20210507-123437-285.png
20210507-123502-114.png
20210507-123527-065.png
20210507-123551-910.png
20210507-123616-529.png
20210507-123641-266.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPermissionToRoot failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121537-711.png
20210507-121603-800.png
20210507-121630-201.png
20210507-121656-502.png
20210507-121722-811.png
20210507-121748-879.png
20210507-121815-263.png
20210507-121841-847.png
20210507-121912-588.png
20210507-121942-096.png
20210507-122008-607.png
20210507-122033-975.png
20210507-122059-178.png
20210507-122124-630.png
20210507-122150-237.png
20210507-122215-423.png
20210507-122240-534.png
20210507-122305-965.png
20210507-122331-062.png
20210507-122356-526.png
20210507-122421-731.png
20210507-122447-130.png
20210507-122512-508.png
20210507-122537-838.png
20210507-122603-196.png
20210507-122628-668.png
20210507-122654-023.png
20210507-122719-442.png
20210507-122744-837.png
20210507-122810-185.png
20210507-122835-720.png
20210507-122901-334.png
20210507-122926-674.png
20210507-122952-114.png
20210507-123017-446.png
20210507-123043-012.png
20210507-123108-192.png
20210507-123133-389.png
20210507-123158-512.png
20210507-123223-688.png
20210507-123248-887.png
20210507-123313-918.png
20210507-123339-253.png
20210507-123404-609.png
20210507-123432-552.png
20210507-123500-332.png
20210507-123526-766.png
20210507-123553-098.png
20210507-123620-679.png
20210507-123648-215.png
20210507-123715-728.png
20210507-123743-378.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121621-040.png
20210507-121645-943.png
20210507-121710-903.png
20210507-121735-784.png
20210507-121800-758.png
20210507-121825-721.png
20210507-121850-957.png
20210507-121915-735.png
20210507-121941-090.png
20210507-122007-380.png
20210507-122033-981.png
20210507-122100-398.png
20210507-122126-060.png
20210507-122151-335.png
20210507-122216-160.png
20210507-122241-188.png
20210507-122306-573.png
20210507-122331-995.png
20210507-122356-838.png
20210507-122421-869.png
20210507-122447-058.png
20210507-122512-209.png
20210507-122537-263.png
20210507-122602-347.png
20210507-122627-582.png
20210507-122652-727.png
20210507-122717-801.png
20210507-122742-849.png
20210507-122808-156.png
20210507-122833-265.png
20210507-122858-316.png
20210507-122923-285.png
20210507-122948-131.png
20210507-123012-909.png
20210507-123037-739.png
20210507-123102-465.png
20210507-123127-347.png
20210507-123152-151.png
20210507-123217-154.png
20210507-123242-186.png
20210507-123307-071.png
20210507-123331-981.png
20210507-123357-112.png
20210507-123422-848.png
20210507-123448-327.png
20210507-123513-787.png
20210507-123539-205.png
20210507-123604-959.png
20210507-123630-395.png
20210507-123655-961.png
20210507-123721-422.png
20210507-123746-741.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests ResharingToRoot failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121551-079.png
20210507-121617-495.png
20210507-121642-703.png
20210507-121708-927.png
20210507-121735-089.png
20210507-121801-164.png
20210507-121826-072.png
20210507-121851-113.png
20210507-121916-077.png
20210507-121940-952.png
20210507-122006-032.png
20210507-122030-881.png
20210507-122055-806.png
20210507-122120-678.png
20210507-122145-460.png
20210507-122210-478.png
20210507-122235-286.png
20210507-122300-176.png
20210507-122324-909.png
20210507-122349-874.png
20210507-122414-735.png
20210507-122439-488.png
20210507-122504-558.png
20210507-122529-218.png
20210507-122553-973.png
20210507-122618-666.png
20210507-122643-183.png
20210507-122707-651.png
20210507-122732-113.png
20210507-122756-445.png
20210507-122820-936.png
20210507-122845-378.png
20210507-122910-043.png
20210507-122934-660.png
20210507-123000-190.png
20210507-123025-823.png
20210507-123051-609.png
20210507-123117-402.png
20210507-123141-839.png
20210507-123206-244.png
20210507-123230-583.png
20210507-123254-971.png
20210507-123319-335.png
20210507-123343-749.png
20210507-123409-580.png
20210507-123435-329.png
20210507-123501-078.png
20210507-123526-810.png
20210507-123553-028.png
20210507-123619-091.png
20210507-123644-574.png
20210507-123710-089.png
20210507-123739-713.png
20210507-123809-738.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121548-266.png
20210507-121614-815.png
20210507-121641-350.png
20210507-121707-823.png
20210507-121734-245.png
20210507-121800-761.png
20210507-121827-289.png
20210507-121853-705.png
20210507-121920-141.png
20210507-121946-405.png
20210507-122012-872.png
20210507-122039-435.png
20210507-122105-887.png
20210507-122132-466.png
20210507-122158-902.png
20210507-122225-428.png
20210507-122251-779.png
20210507-122318-088.png
20210507-122343-298.png
20210507-122407-459.png
20210507-122431-593.png
20210507-122455-739.png
20210507-122519-976.png
20210507-122544-156.png
20210507-122608-337.png
20210507-122632-375.png
20210507-122656-513.png
20210507-122720-786.png
20210507-122745-006.png
20210507-122808-985.png
20210507-122833-017.png
20210507-122857-015.png
20210507-122921-016.png
20210507-122945-064.png
20210507-123009-128.png
20210507-123033-114.png
20210507-123057-151.png
20210507-123121-115.png
20210507-123145-031.png
20210507-123208-975.png
20210507-123232-924.png
20210507-123256-907.png
20210507-123320-922.png
20210507-123344-920.png
20210507-123408-889.png
20210507-123432-842.png
20210507-123456-851.png
20210507-123520-823.png
20210507-123544-869.png
20210507-123608-832.png
20210507-123632-797.png
20210507-123656-747.png
20210507-123720-719.png
20210507-123744-678.png
20210507-123808-628.png
20210507-123832-559.png
20210507-123856-493.png
20210507-123920-423.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121607-183.png
20210507-121631-885.png
20210507-121656-646.png
20210507-121721-138.png
20210507-121745-787.png
20210507-121810-531.png
20210507-121835-080.png
20210507-121859-639.png
20210507-121924-524.png
20210507-121949-231.png
20210507-122016-694.png
20210507-122044-203.png
20210507-122111-961.png
20210507-122139-372.png
20210507-122204-587.png
20210507-122230-223.png
20210507-122255-813.png
20210507-122321-353.png
20210507-122346-919.png
20210507-122412-502.png
20210507-122437-436.png
20210507-122502-138.png
20210507-122526-634.png
20210507-122551-210.png
20210507-122617-408.png
20210507-122643-715.png
20210507-122708-707.png
20210507-122734-144.png
20210507-122800-963.png
20210507-122827-256.png
20210507-122854-786.png
20210507-122922-341.png
20210507-122949-741.png
20210507-123017-176.png
20210507-123041-654.png
20210507-123106-146.png
20210507-123130-547.png
20210507-123155-034.png
20210507-123221-231.png
20210507-123247-462.png
20210507-123313-432.png
20210507-123339-310.png
20210507-123405-397.png
20210507-123431-455.png
20210507-123456-148.png
20210507-123520-815.png
20210507-123545-571.png
20210507-123610-290.png
20210507-123635-017.png
20210507-123659-720.png
20210507-123724-185.png
20210507-123748-557.png
20210507-123813-014.png
20210507-123837-417.png
20210507-123904-696.png
20210507-123932-098.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIResharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121543-617.png
20210507-121611-636.png
20210507-121639-214.png
20210507-121706-714.png
20210507-121734-215.png
20210507-121801-511.png
20210507-121829-332.png
20210507-121857-481.png
20210507-121926-063.png
20210507-121954-225.png
20210507-122023-328.png
20210507-122052-202.png
20210507-122119-758.png
20210507-122147-077.png
20210507-122214-619.png
20210507-122242-145.png
20210507-122309-548.png
20210507-122336-935.png
20210507-122405-765.png
20210507-122434-295.png
20210507-122503-049.png
20210507-122531-773.png
20210507-122600-725.png
20210507-122629-622.png
20210507-122658-188.png
20210507-122726-972.png
20210507-122759-754.png
20210507-122832-636.png
20210507-122901-298.png
20210507-122929-782.png
20210507-122958-614.png
20210507-123027-415.png
20210507-123056-057.png
20210507-123124-727.png
20210507-123152-031.png
20210507-123219-439.png
20210507-123246-888.png
20210507-123314-425.png
20210507-123341-703.png
20210507-123409-218.png
20210507-123436-864.png
20210507-123504-210.png
20210507-123531-313.png
20210507-123557-779.png
20210507-123624-916.png
20210507-123652-076.png
20210507-123719-174.png
20210507-123746-431.png
20210507-123813-521.png
20210507-123840-310.png
20210507-123907-215.png
20210507-123934-298.png
20210507-124001-126.png
20210507-124028-071.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121542-568.png
20210507-121607-131.png
20210507-121631-765.png
20210507-121656-208.png
20210507-121720-277.png
20210507-121744-200.png
20210507-121808-948.png
20210507-121833-495.png
20210507-121857-762.png
20210507-121922-067.png
20210507-121946-386.png
20210507-122010-538.png
20210507-122034-616.png
20210507-122058-353.png
20210507-122122-413.png
20210507-122146-558.png
20210507-122210-932.png
20210507-122235-180.png
20210507-122259-417.png
20210507-122323-678.png
20210507-122347-368.png
20210507-122411-743.png
20210507-122436-573.png
20210507-122501-644.png
20210507-122525-810.png
20210507-122550-005.png
20210507-122615-672.png
20210507-122641-089.png
20210507-122708-173.png
20210507-122735-239.png
20210507-122802-002.png
20210507-122828-698.png
20210507-122855-739.png
20210507-122922-595.png
20210507-122949-346.png
20210507-123016-379.png
20210507-123041-256.png
20210507-123106-325.png
20210507-123131-244.png
20210507-123155-926.png
20210507-123220-931.png
20210507-123245-950.png
20210507-123310-659.png
20210507-123335-288.png
20210507-123359-952.png
20210507-123424-546.png
20210507-123449-081.png
20210507-123513-651.png
20210507-123538-096.png
20210507-123602-530.png
20210507-123627-567.png
20210507-123652-664.png
20210507-123719-330.png
20210507-123745-816.png
20210507-123811-991.png
20210507-123837-964.png
20210507-123902-141.png
20210507-123926-422.png
20210507-123950-991.png
20210507-124015-732.png
20210507-124040-252.png
20210507-124104-621.png
20210507-124129-332.png
20210507-124154-360.png
20210507-124218-861.png
20210507-124243-334.png
20210507-124307-778.png
20210507-124332-367.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121539-221.png
20210507-121603-921.png
20210507-121628-368.png
20210507-121652-766.png
20210507-121717-133.png
20210507-121741-533.png
20210507-121805-933.png
20210507-121830-249.png
20210507-121854-681.png
20210507-121918-962.png
20210507-121943-270.png
20210507-122007-632.png
20210507-122031-924.png
20210507-122056-239.png
20210507-122120-586.png
20210507-122144-845.png
20210507-122209-157.png
20210507-122233-563.png
20210507-122257-892.png
20210507-122322-235.png
20210507-122346-466.png
20210507-122410-688.png
20210507-122436-097.png
20210507-122501-495.png
20210507-122526-970.png
20210507-122552-254.png
20210507-122617-513.png
20210507-122642-911.png
20210507-122708-143.png
20210507-122733-592.png
20210507-122758-832.png
20210507-122824-069.png
20210507-122849-415.png
20210507-122914-752.png
20210507-122940-044.png
20210507-123005-335.png
20210507-123030-414.png
20210507-123055-914.png
20210507-123121-467.png
20210507-123147-071.png
20210507-123211-834.png
20210507-123236-029.png
20210507-123300-192.png
20210507-123324-390.png
20210507-123348-624.png
20210507-123412-695.png
20210507-123438-483.png
20210507-123504-235.png
20210507-123530-003.png
20210507-123555-723.png
20210507-123621-494.png
20210507-123647-283.png
20210507-123713-063.png
20210507-123738-752.png
20210507-123804-299.png
20210507-123829-779.png
20210507-123855-429.png
20210507-123920-893.png
20210507-123946-379.png
20210507-124012-145.png
20210507-124037-759.png
20210507-124103-408.png
20210507-124128-990.png
20210507-124154-705.png
20210507-124220-288.png
20210507-124245-934.png
20210507-124311-475.png
20210507-124337-042.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121544-530.png
20210507-121609-246.png
20210507-121633-724.png
20210507-121658-106.png
20210507-121722-875.png
20210507-121747-511.png
20210507-121814-272.png
20210507-121841-138.png
20210507-121908-036.png
20210507-121934-837.png
20210507-122001-834.png
20210507-122028-649.png
20210507-122052-849.png
20210507-122117-119.png
20210507-122141-462.png
20210507-122205-782.png
20210507-122229-978.png
20210507-122254-249.png
20210507-122319-176.png
20210507-122344-540.png
20210507-122410-244.png
20210507-122435-657.png
20210507-122501-137.png
20210507-122526-559.png
20210507-122551-936.png
20210507-122617-471.png
20210507-122643-045.png
20210507-122708-516.png
20210507-122733-981.png
20210507-122759-433.png
20210507-122824-981.png
20210507-122850-413.png
20210507-122915-846.png
20210507-122941-195.png
20210507-123006-646.png
20210507-123032-093.png
20210507-123057-509.png
20210507-123122-921.png
20210507-123148-440.png
20210507-123213-887.png
20210507-123239-389.png
20210507-123304-906.png
20210507-123330-418.png
20210507-123356-066.png
20210507-123420-999.png
20210507-123445-348.png
20210507-123509-950.png
20210507-123534-613.png
20210507-123600-280.png
20210507-123626-062.png
20210507-123650-584.png
20210507-123715-176.png
20210507-123739-790.png
20210507-123804-895.png
20210507-123829-592.png
20210507-123853-686.png
20210507-123918-105.png
20210507-123942-420.png
20210507-124007-034.png
20210507-124031-506.png
20210507-124055-953.png
20210507-124120-486.png
20210507-124145-251.png
20210507-124209-989.png
20210507-124234-534.png
20210507-124259-029.png
20210507-124323-344.png
20210507-124347-609.png
20210507-124412-127.png
20210507-124436-657.png
20210507-124501-702.png
20210507-124526-806.png
20210507-124552-038.png
20210507-124617-087.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121544-097.png
20210507-121608-676.png
20210507-121633-885.png
20210507-121659-207.png
20210507-121725-336.png
20210507-121751-151.png
20210507-121815-697.png
20210507-121840-383.png
20210507-121904-728.png
20210507-121928-785.png
20210507-121953-328.png
20210507-122017-742.png
20210507-122042-193.png
20210507-122106-585.png
20210507-122131-117.png
20210507-122155-690.png
20210507-122220-140.png
20210507-122244-660.png
20210507-122308-982.png
20210507-122333-307.png
20210507-122357-750.png
20210507-122422-099.png
20210507-122446-531.png
20210507-122510-870.png
20210507-122535-289.png
20210507-122559-882.png
20210507-122624-368.png
20210507-122648-843.png
20210507-122713-361.png
20210507-122737-766.png
20210507-122802-256.png
20210507-122826-867.png
20210507-122851-925.png
20210507-122917-054.png
20210507-122941-804.png
20210507-123006-817.png
20210507-123031-451.png
20210507-123056-070.png
20210507-123120-932.png
20210507-123145-594.png
20210507-123209-868.png
20210507-123234-191.png
20210507-123258-967.png
20210507-123323-245.png
20210507-123347-491.png
20210507-123411-796.png
20210507-123436-089.png
20210507-123500-305.png
20210507-123524-611.png
20210507-123548-992.png
20210507-123613-119.png
20210507-123637-336.png
20210507-123701-466.png
20210507-123725-617.png
20210507-123750-268.png
20210507-123814-987.png
20210507-123839-671.png
20210507-123904-380.png
20210507-123928-528.png
20210507-123952-711.png
20210507-124016-959.png
20210507-124041-173.png
20210507-124105-413.png
20210507-124129-607.png
20210507-124153-808.png
20210507-124217-957.png
20210507-124242-172.png
20210507-124306-354.png
20210507-124330-489.png
20210507-124354-616.png
20210507-124418-833.png
20210507-124442-941.png
20210507-124507-149.png
20210507-124531-323.png
20210507-124555-600.png
20210507-124619-915.png
20210507-124645-517.png
20210507-124711-296.png
20210507-124736-761.png
20210507-124802-459.png
20210507-124827-091.png
20210507-124851-437.png
20210507-124915-771.png
20210507-124939-901.png
20210507-125004-036.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121614-429.png
20210507-121641-875.png
20210507-121709-453.png
20210507-121736-609.png
20210507-121803-875.png
20210507-121831-008.png
20210507-121858-312.png
20210507-121925-582.png
20210507-121952-668.png
20210507-122019-670.png
20210507-122046-481.png
20210507-122113-332.png
20210507-122141-647.png
20210507-122210-025.png
20210507-122236-987.png
20210507-122303-983.png
20210507-122332-776.png
20210507-122401-508.png
20210507-122431-327.png
20210507-122501-138.png
20210507-122531-011.png
20210507-122601-021.png
20210507-122627-818.png
20210507-122654-768.png
20210507-122721-533.png
20210507-122748-350.png
20210507-122815-180.png
20210507-122842-014.png
20210507-122910-267.png
20210507-122938-626.png
20210507-123006-977.png
20210507-123035-510.png
20210507-123102-170.png
20210507-123128-687.png
20210507-123155-038.png
20210507-123221-519.png
20210507-123247-754.png
20210507-123314-020.png
20210507-123340-182.png
20210507-123406-437.png
20210507-123432-658.png
20210507-123459-032.png
20210507-123525-302.png
20210507-123551-564.png
20210507-123618-561.png
20210507-123645-495.png
20210507-123715-116.png
20210507-123744-592.png
20210507-123814-305.png
20210507-123844-170.png
20210507-123912-642.png
20210507-123941-004.png
20210507-124008-731.png
20210507-124036-366.png
20210507-124104-316.png
20210507-124132-369.png
20210507-124159-247.png
20210507-124226-214.png
20210507-124253-377.png
20210507-124320-381.png
20210507-124347-510.png
20210507-124414-541.png
20210507-124441-491.png
20210507-124508-406.png
20210507-124537-821.png
20210507-124607-151.png
20210507-124634-068.png
20210507-124701-332.png
20210507-124728-719.png
20210507-124755-770.png
20210507-124823-730.png
20210507-124851-264.png
20210507-124918-716.png
20210507-124946-247.png
20210507-125013-231.png
20210507-125039-758.png
20210507-125106-760.png
20210507-125133-656.png
20210507-125202-308.png
20210507-125230-974.png
20210507-125257-436.png
20210507-125323-750.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15348/

20210507-121557-340.png
20210507-121622-971.png
20210507-121648-504.png
20210507-121714-172.png
20210507-121739-805.png
20210507-121805-334.png
20210507-121830-969.png
20210507-121856-542.png
20210507-121921-859.png
20210507-121947-294.png
20210507-122012-937.png
20210507-122037-990.png
20210507-122103-052.png
20210507-122128-092.png
20210507-122153-256.png
20210507-122218-370.png
20210507-122243-422.png
20210507-122308-534.png
20210507-122333-517.png
20210507-122358-516.png
20210507-122423-635.png
20210507-122448-684.png
20210507-122513-620.png
20210507-122539-134.png
20210507-122604-766.png
20210507-122629-789.png
20210507-122654-842.png
20210507-122719-879.png
20210507-122744-925.png
20210507-122809-781.png
20210507-122834-796.png
20210507-122859-762.png
20210507-122924-668.png
20210507-122949-636.png
20210507-123014-533.png
20210507-123039-537.png
20210507-123104-516.png
20210507-123129-413.png
20210507-123154-185.png
20210507-123219-051.png
20210507-123243-913.png
20210507-123308-794.png
20210507-123333-682.png
20210507-123358-644.png
20210507-123423-459.png
20210507-123448-313.png
20210507-123513-124.png
20210507-123537-693.png
20210507-123602-537.png
20210507-123627-385.png
20210507-123652-339.png
20210507-123717-154.png
20210507-123742-005.png
20210507-123806-901.png
20210507-123831-716.png
20210507-123856-321.png
20210507-123920-965.png
20210507-123945-560.png
20210507-124010-046.png
20210507-124034-560.png
20210507-124058-998.png
20210507-124123-525.png
20210507-124148-209.png
20210507-124212-872.png
20210507-124237-458.png
20210507-124302-110.png
20210507-124326-785.png
20210507-124351-485.png
20210507-124416-243.png
20210507-124441-033.png
20210507-124505-801.png
20210507-124530-583.png
20210507-124555-199.png
20210507-124619-912.png
20210507-124644-761.png
20210507-124709-748.png
20210507-124734-458.png
20210507-124759-344.png
20210507-124824-129.png
20210507-124849-005.png
20210507-124913-838.png
20210507-124938-853.png
20210507-125003-470.png
20210507-125028-237.png
20210507-125052-986.png
20210507-125117-674.png
20210507-125142-618.png
20210507-125207-439.png
20210507-125232-215.png
20210507-125257-001.png
20210507-125321-747.png
20210507-125346-430.png
20210507-125411-214.png
20210507-125435-958.png
20210507-125500-591.png
20210507-125525-323.png
20210507-125549-927.png
20210507-125614-671.png
20210507-125639-438.png
20210507-125704-174.png
20210507-125728-904.png
20210507-125753-583.png

pascalwengerter
pascalwengerter approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎯

@kulmann kulmann merged commit 8a2284f into a11y-swarming May 7, 2021
@individual-it individual-it mentioned this pull request May 20, 2021
Closed
@pascalwengerter pascalwengerter deleted the feat/left-sidebar-focus-trap branch May 25, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcus-herrmann marcus-herrmann marcus-herrmann left review comments

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LukasHirt @ownclouders @pascalwengerter @marcus-herrmann @kulmann