-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancher Trashbin a11y #5046
Enhancher Trashbin a11y #5046
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@pascalwengerter 'Empty' was not the best word, the context is missing a bit and we easily translate (and will accidentally) with 'Leer' in german. |
e3eaf36
to
f7a0494
Compare
cc92b31
to
8fd6fa9
Compare
cb0e9b8
to
003aa28
Compare
@pascalwengerter decided to don't show the empty button if there are no resources, because we already have the no resources indicator here: |
003aa28
to
0e66948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUISharingInternalUsersRoot1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests Favorites failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests SharingPublicBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15232/
|
Description
Add more context to the empty trash bin button text and only render it, if resources are present.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: