Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancher Trashbin a11y #5046

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Enhancher Trashbin a11y #5046

merged 1 commit into from
Apr 30, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 29, 2021 •
edited
Loading

Description

Add more context to the empty trash bin button text and only render it, if resources are present.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 29, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear
Copy link
Contributor Author

@pascalwengerter 'Empty' was not the best word, the context is missing a bit and we easily translate (and will accidentally) with 'Leer' in german.
But we could also change Empty -> Clear

@AlexAndBear AlexAndBear mentioned this pull request Apr 29, 2021
Closed
10 tasks
@AlexAndBear AlexAndBear force-pushed the enhanche-trashbin-wording branch 2 times, most recently from cb0e9b8 to 003aa28 Compare April 29, 2021 13:46
@AlexAndBear
Copy link
Contributor Author

@pascalwengerter decided to don't show the empty button if there are no resources, because we already have the no resources indicator here:

Screenshot from 2021-04-29 15-47-35

@AlexAndBear AlexAndBear changed the title change l10n string Enhancher Trashbin a11y Apr 30, 2021
JammingBen
JammingBen approved these changes Apr 30, 2021
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075627-341.png
20210430-075659-362.png
20210430-075731-209.png
20210430-075802-770.png
20210430-075834-892.png
20210430-075906-931.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075601-595.png
20210430-075635-702.png
20210430-075706-551.png
20210430-075737-305.png
20210430-075810-509.png
20210430-075842-965.png
20210430-075913-840.png
20210430-075946-589.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075803-618.png
20210430-075833-908.png
20210430-075905-255.png
20210430-075935-791.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075750-463.png
20210430-075817-378.png
20210430-075844-875.png
20210430-075912-473.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075634-092.png
20210430-075707-589.png
20210430-075740-258.png
20210430-075811-099.png
20210430-075952-926.png
20210430-080025-460.png
20210430-080100-147.png
20210430-080134-777.png
20210430-080223-966.png
20210430-080257-657.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075821-820.png
20210430-075915-438.png
20210430-080020-296.png
20210430-080051-381.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075905-838.png
20210430-075955-316.png
20210430-080240-601.png
20210430-080309-929.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075910-247.png
20210430-075944-214.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075652-791.png
20210430-075727-307.png
20210430-075800-165.png
20210430-075833-750.png
20210430-075946-966.png
20210430-080019-774.png
20210430-080052-283.png
20210430-080124-853.png
20210430-080157-372.png
20210430-080229-520.png
20210430-080302-971.png
20210430-080335-351.png
20210430-080415-963.png
20210430-080458-109.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075857-928.png
20210430-075943-449.png
20210430-080032-466.png
20210430-080120-842.png
20210430-080202-456.png
20210430-080244-530.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075926-686.png
20210430-075956-205.png
20210430-080124-678.png
20210430-080155-785.png
20210430-080226-867.png
20210430-080257-939.png
20210430-080448-362.png
20210430-080519-335.png
20210430-080620-688.png
20210430-080652-065.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075846-278.png
20210430-075925-725.png
20210430-080011-975.png
20210430-080058-494.png
20210430-080139-924.png
20210430-080221-659.png
20210430-080719-248.png
20210430-080749-584.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075728-246.png
20210430-075758-445.png
20210430-075828-878.png
20210430-075858-944.png
20210430-080020-418.png
20210430-080051-248.png
20210430-080121-232.png
20210430-080151-127.png
20210430-080220-497.png
20210430-080250-422.png
20210430-080320-793.png
20210430-080350-952.png
20210430-080420-290.png
20210430-080450-174.png
20210430-080520-248.png
20210430-080550-075.png
20210430-080620-027.png
20210430-080651-614.png
20210430-080735-092.png
20210430-080805-441.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075551-709.png
20210430-075626-222.png
20210430-075657-810.png
20210430-075729-450.png
20210430-075800-840.png
20210430-075832-021.png
20210430-075903-069.png
20210430-075934-031.png
20210430-080005-176.png
20210430-080036-231.png
20210430-080126-254.png
20210430-080200-706.png
20210430-080231-491.png
20210430-080302-570.png
20210430-080335-327.png
20210430-080406-798.png
20210430-080439-300.png
20210430-080511-247.png
20210430-080545-939.png
20210430-080620-827.png
20210430-080655-579.png
20210430-080730-406.png
20210430-080823-362.png
20210430-080855-551.png
20210430-080927-275.png
20210430-080959-381.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075930-538.png
20210430-080007-715.png
20210430-080041-798.png
20210430-080116-464.png
20210430-080204-414.png
20210430-080237-740.png
20210430-080311-276.png
20210430-080345-974.png
20210430-080416-165.png
20210430-080447-653.png
20210430-080521-469.png
20210430-080553-105.png
20210430-080623-805.png
20210430-080655-511.png
20210430-080901-903.png
20210430-080935-944.png
20210430-081006-683.png
20210430-081036-527.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075722-836.png
20210430-075809-901.png
20210430-075840-348.png
20210430-075910-801.png
20210430-080354-570.png
20210430-080425-140.png
20210430-080828-396.png
20210430-080900-298.png
20210430-081152-123.png
20210430-081241-912.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075621-312.png
20210430-075650-480.png
20210430-075807-366.png
20210430-075835-438.png
20210430-075903-467.png
20210430-075931-361.png
20210430-075959-379.png
20210430-080027-824.png
20210430-080055-888.png
20210430-080123-941.png
20210430-080149-945.png
20210430-080215-191.png
20210430-080240-589.png
20210430-080305-752.png
20210430-080333-120.png
20210430-080401-247.png
20210430-080429-573.png
20210430-080457-871.png
20210430-080525-790.png
20210430-080553-827.png
20210430-080621-646.png
20210430-080649-701.png
20210430-080725-208.png
20210430-080753-166.png
20210430-080821-256.png
20210430-080849-250.png
20210430-080944-274.png
20210430-081013-054.png
20210430-081041-553.png
20210430-081110-022.png
20210430-081139-751.png
20210430-081208-652.png
20210430-081236-936.png
20210430-081305-310.png
20210430-081400-665.png
20210430-081429-103.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075744-285.png
20210430-075814-382.png
20210430-075843-583.png
20210430-075913-443.png
20210430-080217-384.png
20210430-080247-777.png
20210430-080318-789.png
20210430-080350-488.png
20210430-080436-411.png
20210430-080506-139.png
20210430-080537-336.png
20210430-080606-722.png
20210430-080637-929.png
20210430-080709-637.png
20210430-080740-074.png
20210430-080810-753.png
20210430-080838-827.png
20210430-080906-186.png
20210430-080936-418.png
20210430-081007-717.png
20210430-081039-140.png
20210430-081110-002.png
20210430-081139-574.png
20210430-081209-800.png
20210430-081240-678.png
20210430-081310-437.png
20210430-081341-861.png
20210430-081412-904.png
20210430-081502-080.png
20210430-081535-452.png
20210430-081608-805.png
20210430-081642-168.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075826-106.png
20210430-075858-037.png
20210430-075930-617.png
20210430-080002-924.png
20210430-080034-363.png
20210430-080106-247.png
20210430-080153-866.png
20210430-080225-076.png
20210430-080256-348.png
20210430-080327-518.png
20210430-080359-520.png
20210430-080430-827.png
20210430-080459-296.png
20210430-080526-439.png
20210430-080557-855.png
20210430-080630-151.png
20210430-080701-181.png
20210430-080732-323.png
20210430-080824-947.png
20210430-080902-726.png
20210430-080935-075.png
20210430-081006-312.png
20210430-081038-212.png
20210430-081110-206.png
20210430-081142-034.png
20210430-081214-303.png
20210430-081300-419.png
20210430-081331-467.png
20210430-081402-415.png
20210430-081433-244.png
20210430-081503-895.png
20210430-081534-647.png
20210430-081605-927.png
20210430-081637-416.png
20210430-081706-939.png
20210430-081736-778.png
20210430-081807-503.png
20210430-081838-271.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075651-566.png
20210430-075726-349.png
20210430-075801-296.png
20210430-075835-853.png
20210430-075910-513.png
20210430-075945-079.png
20210430-080150-077.png
20210430-080223-026.png
20210430-080256-258.png
20210430-080329-063.png
20210430-080402-168.png
20210430-080435-231.png
20210430-080507-742.png
20210430-080541-236.png
20210430-080614-737.png
20210430-080647-983.png
20210430-080721-840.png
20210430-080755-301.png
20210430-080828-676.png
20210430-080902-001.png
20210430-080935-289.png
20210430-081008-865.png
20210430-081041-948.png
20210430-081115-324.png
20210430-081148-357.png
20210430-081221-254.png
20210430-081254-220.png
20210430-081327-301.png
20210430-081400-423.png
20210430-081433-582.png
20210430-081506-846.png
20210430-081540-854.png
20210430-081613-316.png
20210430-081645-264.png
20210430-081717-342.png
20210430-081749-305.png
20210430-081822-417.png
20210430-081855-639.png
20210430-081927-575.png
20210430-082000-984.png
20210430-082033-553.png
20210430-082105-837.png
20210430-082138-658.png
20210430-082210-695.png
20210430-082242-889.png
20210430-082314-812.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15232/

20210430-075627-151.png
20210430-075657-610.png
20210430-075730-239.png
20210430-075801-617.png
20210430-075832-512.png
20210430-075901-951.png
20210430-075934-240.png
20210430-080005-281.png
20210430-080036-483.png
20210430-080108-241.png
20210430-080140-796.png
20210430-080213-195.png
20210430-080245-635.png
20210430-080316-706.png
20210430-080347-436.png
20210430-080418-671.png
20210430-080450-561.png
20210430-080521-312.png
20210430-080550-619.png
20210430-080621-453.png
20210430-080652-682.png
20210430-080724-281.png
20210430-080755-568.png
20210430-080827-942.png
20210430-080900-259.png
20210430-080930-238.png
20210430-081000-788.png
20210430-081031-882.png
20210430-081103-301.png
20210430-081134-819.png
20210430-081206-640.png
20210430-081238-931.png
20210430-081310-695.png
20210430-081342-429.png
20210430-081414-479.png
20210430-081446-994.png
20210430-081518-428.png
20210430-081550-107.png
20210430-081621-161.png
20210430-081652-317.png
20210430-081723-143.png
20210430-081754-720.png
20210430-081824-167.png
20210430-081853-767.png
20210430-081922-234.png
20210430-081950-877.png
20210430-082022-219.png
20210430-082051-807.png
20210430-082126-220.png
20210430-082202-715.png
20210430-082238-861.png
20210430-082312-666.png
20210430-082344-123.png
20210430-082414-357.png
20210430-082444-728.png
20210430-082514-844.png
20210430-082543-326.png
20210430-082611-886.png
20210430-082640-366.png
20210430-082708-988.png
20210430-082737-743.png
20210430-082806-151.png
20210430-082834-588.png
20210430-082903-378.png
20210430-082933-436.png
20210430-083001-975.png
20210430-083030-593.png
20210430-083059-333.png
20210430-083128-003.png
20210430-083158-030.png
20210430-083230-015.png
20210430-083301-495.png
20210430-083333-528.png
20210430-083405-532.png
20210430-083437-401.png
20210430-083509-252.png
20210430-083541-230.png
20210430-083612-886.png
20210430-083644-099.png
20210430-083715-450.png
20210430-083746-843.png
20210430-083818-091.png
20210430-083849-239.png
20210430-083920-570.png
20210430-083951-971.png
20210430-084023-203.png
20210430-084054-320.png
20210430-084125-502.png
20210430-084156-651.png
20210430-084227-830.png
20210430-084259-067.png
20210430-084330-763.png
20210430-084401-795.png
20210430-084432-911.png
20210430-084503-891.png
20210430-084534-707.png
20210430-084605-471.png
20210430-084636-339.png
20210430-084707-055.png
20210430-084737-969.png
20210430-084809-611.png
20210430-084841-144.png

@AlexAndBear AlexAndBear merged commit cb2c278 into a11y-swarming Apr 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the enhanche-trashbin-wording branch April 30, 2021 08:51
@individual-it individual-it mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @ownclouders @JammingBen