Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip editors route check on empty array #5095

Merged
merged 1 commit into from
May 10, 2021
Merged

Skip editors route check on empty array #5095

merged 1 commit into from
May 10, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 10, 2021

Description

If an extension doesn't define valid routes it should be allowed for all routes by default. That behaviour was not working properly and is fixed with this PR.

How Has This Been Tested?

  • drone

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this May 10, 2021
pascalwengerter
pascalwengerter approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@kulmann kulmann merged commit 39dbcb0 into master May 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-file-actions branch May 10, 2021 10:27
@individual-it individual-it mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @pascalwengerter