Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collaborator tag for currentUser in sidebar #5112

Merged

Conversation

pascalwengerter
Copy link
Contributor

Description

Role setting didn't look up parent file ownership and announced the current user as "owner" even though they might've only been viewer, editor etc. This has been fixed now

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15470/

webUIMoveFilesFolders-moveFiles-feature-105.png

webUIMoveFilesFolders-moveFiles-feature-105.png

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15471/

webUIMoveFilesFolders-moveFiles-feature-105.png

webUIMoveFilesFolders-moveFiles-feature-105.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15477/

webUIMoveFilesFolders-moveFiles-feature-105.png

webUIMoveFilesFolders-moveFiles-feature-105.png

@pascalwengerter pascalwengerter merged commit c9ec636 into master May 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the 170502021_fix-collaborator-tag-inside-shares branch May 17, 2021 16:24
diocas pushed a commit to cernbox/web that referenced this pull request May 19, 2021
…ator-tag-inside-shares

Fix collaborator tag for currentUser in sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants