Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index route for the OC10 integration #5201

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Add index route for the OC10 integration #5201

merged 4 commits into from
Jun 9, 2021

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jun 7, 2021

Description

Added an index route for the OC10 integration which gets called when opening http://your-server/index.php/apps/web. The route basically redirects to the same URL while appending /index.html, as this is the correct URL for accessing the Web UI. Setting Web as default layout would result in an endless redirect loop otherwise.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes in routes.php needed? 🤔

@JammingBen
Copy link
Collaborator Author

@kulmann Ahh good catch, this one got lost indeed. Added 👍

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16019/

webUIFilesDetails-fileDetails-feature-116.png

webUIFilesDetails-fileDetails-feature-116.png

webUIFilesDetails-fileDetails-feature-172.png

webUIFilesDetails-fileDetails-feature-172.png

webUIFilesDetails-fileDetails-feature-66.png

webUIFilesDetails-fileDetails-feature-66.png

webUIFilesDetails-fileDetails-feature-82.png

webUIFilesDetails-fileDetails-feature-82.png

webUIFilesDetails-fileDetails-feature-99.png

webUIFilesDetails-fileDetails-feature-99.png

webUIFilesList-sort-feature-51.png

webUIFilesList-sort-feature-51.png

webUIFilesList-sort-feature-72.png

webUIFilesList-sort-feature-72.png

💥 Acceptance tests webUIFiles2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16020/

webUIFilesDetails-fileDetails-feature-116.png

webUIFilesDetails-fileDetails-feature-116.png

webUIFilesDetails-fileDetails-feature-172.png

webUIFilesDetails-fileDetails-feature-172.png

webUIFilesDetails-fileDetails-feature-66.png

webUIFilesDetails-fileDetails-feature-66.png

webUIFilesDetails-fileDetails-feature-82.png

webUIFilesDetails-fileDetails-feature-82.png

webUIFilesDetails-fileDetails-feature-99.png

webUIFilesDetails-fileDetails-feature-99.png

webUIFilesList-sort-feature-51.png

webUIFilesList-sort-feature-51.png

webUIFilesList-sort-feature-72.png

webUIFilesList-sort-feature-72.png

💥 Acceptance tests webUIFiles2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16022/

webUITrashbinRestore-trashbinRestore-feature-138.png

webUITrashbinRestore-trashbinRestore-feature-138.png

webUITrashbinRestore-trashbinRestore-feature-14.png

webUITrashbinRestore-trashbinRestore-feature-14.png

webUITrashbinRestore-trashbinRestore-feature-181.png

webUITrashbinRestore-trashbinRestore-feature-181.png

webUITrashbinRestore-trashbinRestore-feature-222.png

webUITrashbinRestore-trashbinRestore-feature-222.png

webUITrashbinRestore-trashbinRestore-feature-241.png

webUITrashbinRestore-trashbinRestore-feature-241.png

webUITrashbinRestore-trashbinRestore-feature-260.png

webUITrashbinRestore-trashbinRestore-feature-260.png

webUITrashbinRestore-trashbinRestore-feature-30.png

webUITrashbinRestore-trashbinRestore-feature-30.png

💥 Acceptance tests Trashbin failed. The build is cancelled...

@JammingBen JammingBen requested a review from kulmann June 8, 2021 14:45
@kulmann kulmann added Web-Fastlane Priority:p2-high Escalation, on top of current planning, release blocker labels Jun 9, 2021
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🥇

@kulmann kulmann merged commit ccaac1f into master Jun 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the oc10-index-route branch June 9, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ownCloud Web as the default frontend
5 participants