unit tests for SidebarQuota.vue #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
individual-it
force-pushed
the
SidebarQuotaUnitTests2
branch
from
ebed240
to
1824503
Compare
45 tasks
individual-it
force-pushed
the
SidebarQuotaUnitTests2
branch
from
1824503
to
99d9493
Compare
kulmann
requested changes
Jun 10, 2021
| @@ -22,7 +22,7 @@ export default { | |||
| ...mapGetters(['quota']), | |||
|
|
|||
| usedQuota() { | |||
| return getResourceSize(this.quota.used) | |||
| return getResourceSize(this.quota.used) || '0 B' | |||
There was a problem hiding this comment.
Can't we just change getResourceSize so that it treats a negative number as 0?
like this:
size = (size < 0) ? 0 : size
instead of the return ''.
There was a problem hiding this comment.
yes you are right. My thought was that the same function is also defined in
and used in https://github.com/owncloud/web/blob/f46085ad7dba7cfc7d35a953c796714e0e88b4e1/packages/web-app-files/src/components/InfoSelectedResources.vueso in the next step I wanted to consolidate both functions (not sure where it has to be placed to be used from both though)
Now looking at
InfoSelectedResources.vue in detail I think returning 0 instead of '' would not harm there ether
There was a problem hiding this comment.
We introduced packages/web-pkg a while ago for shared code, I think it would be good to have it there.
individual-it
force-pushed
the
SidebarQuotaUnitTests2
branch
from
99d9493
to
a5d9b2d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
0 B of 2 GBas quota in case of a negative number given as used quota and not onlyof 2 GBRelated Issue
part of #5217
Motivation and Context
increase unit test coverage
Types of changes
Checklist:
Open tasks: