Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Try Vue3 compat mode #5368

Closed
wants to merge 1 commit into from
Closed

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Jun 24, 2021

Description

Just spent an hour hacking on this with @fschade, we got it to build successfully but didn't manage to get the Vue instance to accept the (new) translations plugin. Saving this as WIP so anyone can try and continue

Related Issue

Motivation and Context

See issue

Types of changes

  • Technical debt

Open tasks:

  • Update the way Vue + vuex are initialized
  • Fix all deprecation warnings
  • Update dependencies, remove dependencies

@update-docs
Copy link

update-docs bot commented Jun 24, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

rollup.config.js Outdated
livereload({
watch: 'dist'
})
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove livereload?

If you remove it here for a reason, then the imports and references in package.json and yarn.lock should be removed as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the hint and yes technically you're right. This is/was a draft PR and something about livereload broke the build process (and we didn't bother investigating there since it was a hacky "let's see how far we get" anyways)

Will get fixed in the cleanup if/once we continue with this PR ;)

@pascalwengerter
Copy link
Contributor Author

Please nobody put any effort into this before #5752 has been merged - I'll rebase it then and we can continue working on it with a way better setup

@pascalwengerter
Copy link
Contributor Author

Please nobody put any effort into this before #5752 has been merged - I'll rebase it then and we can continue working on it with a way better setup

Rebased this branch, doesn't build anymore with what I expect to be a postcss error. @fschade can you maybe take a look?

@dschmidt dschmidt mentioned this pull request Dec 8, 2022
29 tasks
@pascalwengerter
Copy link
Contributor Author

I'll close this as obsolete, it is linked in the relevant Vue3-update-issues but most likely will be superseded by a new PR - looking forward!

@kulmann kulmann deleted the try-vue3-compat branch September 5, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants