-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Try Vue3 compat mode #5368
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
cd8b2a1
to
ee22fcc
Compare
rollup.config.js
Outdated
livereload({ | ||
watch: 'dist' | ||
}) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove livereload?
If you remove it here for a reason, then the imports and references in package.json and yarn.lock should be removed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the hint and yes technically you're right. This is/was a draft PR and something about livereload broke the build process (and we didn't bother investigating there since it was a hacky "let's see how far we get" anyways)
Will get fixed in the cleanup if/once we continue with this PR ;)
Please nobody put any effort into this before #5752 has been merged - I'll rebase it then and we can continue working on it with a way better setup |
ee22fcc
to
4f345b7
Compare
4f345b7
to
b866a62
Compare
I'll close this as obsolete, it is linked in the relevant Vue3-update-issues but most likely will be superseded by a new PR - looking forward! |
Description
Just spent an hour hacking on this with @fschade, we got it to build successfully but didn't manage to get the Vue instance to accept the (new) translations plugin. Saving this as WIP so anyone can try and continue
Related Issue
Motivation and Context
See issue
Types of changes
Open tasks: