Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for resources mixin #5642

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Added unit tests for resources mixin #5642

merged 1 commit into from
Aug 12, 2021

Conversation

kiranparajuli589
Copy link
Contributor

Description

added unit tests for resources mixin

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 6, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kiranparajuli589 kiranparajuli589 requested review from saw-jan and dpakach and removed request for kulmann, pascalwengerter and fschade August 6, 2021 08:45
@kiranparajuli589 kiranparajuli589 self-assigned this Aug 6, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 mentioned this pull request Aug 10, 2021
Closed
53 tasks
saw-jan
saw-jan reviewed Aug 10, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dpakach
dpakach reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@individual-it individual-it merged commit 66d02fc into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the unittest-mixin-resources branch August 12, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@dpakach dpakach dpakach left review comments

@individual-it individual-it individual-it approved these changes

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranparajuli589 @individual-it @dpakach @saw-jan