Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that unreachable applications let the whole system die #5813

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Fix that unreachable applications let the whole system die #5813

merged 2 commits into from
Sep 30, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 16, 2021

Description

On top of #5752 this PR now brings back that a misconfigured or unreachable app fails silently and only logs the error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 16, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann self-assigned this Sep 16, 2021
@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19083/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

pascalwengerter
pascalwengerter reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this? 🤔

@fschade
Copy link
Collaborator

fschade commented Sep 29, 2021

added tests, can be merged after ci is green

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/19286/34/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

pascalwengerter
pascalwengerter approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/19299/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:111

@kulmann kulmann merged commit 70ecfb5 into master Sep 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the skeletor-fix-app-config branch September 30, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @ownclouders @fschade @pascalwengerter