Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deployment-examples] add wopi to deployment example #5899

Merged
merged 2 commits into from
Oct 14, 2021
Merged

[deployment-examples] add wopi to deployment example #5899

merged 2 commits into from
Oct 14, 2021

Conversation

wkloucek
Copy link
Contributor

Description

add wopi to deployment example so that the latest app provider integration can be showcased on https://ocis.ocis-web.latest.owncloud.works

Related Issue

Motivation and Context

Showcase all features of Web

How Has This Been Tested?

  • docker-compose up -d

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@wkloucek wkloucek marked this pull request as ready for review October 12, 2021 14:18
@wkloucek wkloucek changed the title add wopi to deployment example [deployment-examples] add wopi to deployment example Oct 12, 2021
@pascalwengerter
Copy link
Contributor

[deployment-examples] in the PR title doesn't do anything, should we alias it to docs-only since the acceptance tests don't need to be run if those files are being changed?

@wkloucek
Copy link
Contributor Author

[deployment-examples] in the PR title doesn't do anything, should we alias it to docs-only since the acceptance tests don't need to be run if those files are being changed?

It doesn't anything than showing it's not dealing with the code of oC Web. We can not use docs-only since that would not trigger the actual deployment.

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19571/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15
    💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek
Copy link
Contributor Author

@pascalwengerter let's merge?

pascalwengerter
pascalwengerter approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care!

@pascalwengerter pascalwengerter merged commit 89be3c7 into master Oct 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-wopi-to-example-deployment branch October 14, 2021 10:18
@wkloucek wkloucek mentioned this pull request Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @pascalwengerter @ownclouders