Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL handling to markdown-editor (fixes #5928) #6134

Merged
merged 6 commits into from
Jan 23, 2022
Merged

Add URL handling to markdown-editor (fixes #5928) #6134

merged 6 commits into from
Jan 23, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Dec 11, 2021

Description

This adds URL handling to the markdown editor. Allows us to return to the source folder of the file and to reopen the editor on page reload.

I copied a bit of code from the web-app-mediaviewer. Where can we share this kind of code?

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Dec 11, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10iPhoneNotifications https://drone.owncloud.com/owncloud/web/20915/48/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/20915/44/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/20915/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10XGAPortraitNotifications https://drone.owncloud.com/owncloud/web/20915/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/20915/51/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@dschmidt dschmidt changed the title Add URL handling to markdown-editor (fixes #5928) WIP: Add URL handling to markdown-editor (fixes #5928) Dec 13, 2021
@dschmidt
Copy link
Member Author

This fixes a few issues already, but should become way more useful and more resilient after #6156 is merged and it's ported to those apis.

@dschmidt
Copy link
Member Author

Make sure this is fixed by this PR: #5276

@kulmann
Copy link
Contributor

kulmann commented Jan 23, 2022

#6290 is merged, please rebase :-)

@dschmidt dschmidt changed the title WIP: Add URL handling to markdown-editor (fixes #5928) Add URL handling to markdown-editor (fixes #5928) Jan 23, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22108/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/22108/65/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:78

@kulmann kulmann merged commit f953387 into master Jan 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_5928 branch January 23, 2022 12:19
@diocas
Copy link
Contributor

diocas commented Jan 24, 2022

@dschmidt @kulmann this PR introduced, at least, into drawio the same issue as reported in #6069 and #6045 :
If you set the auth: false into the routes, then if I try to directly (before being authenticated) open a file, I'm never redirected to the idp and the page is blank.

I don't know if the solution should be to create separate routes with auth on and off (as I did as a quick workaround in #6151) or if the new composable logic should check the auth status for personal routes.

@kulmann
Copy link
Contributor

kulmann commented Jan 24, 2022

I'm currently looking into building a composable that handles the authentication redirect. I'd like to avoid adding extra routes for public links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

closing the file editor routes back to all files page
4 participants