-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URL handling to markdown-editor (fixes #5928) #6134
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
SonarCloud Quality Gate failed. |
Results for oC10iPhoneNotifications https://drone.owncloud.com/owncloud/web/20915/48/1 |
Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/20915/44/1 |
Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/20915/46/1 |
Results for oC10XGAPortraitNotifications https://drone.owncloud.com/owncloud/web/20915/45/1 |
Results for oCISBasic https://drone.owncloud.com/owncloud/web/20915/51/1 |
This fixes a few issues already, but should become way more useful and more resilient after #6156 is merged and it's ported to those apis. |
Make sure this is fixed by this PR: #5276 |
#6290 is merged, please rebase :-) |
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22108/15/1
|
Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/22108/65/1
|
@dschmidt @kulmann this PR introduced, at least, into drawio the same issue as reported in #6069 and #6045 : I don't know if the solution should be to create separate routes with auth on and off (as I did as a quick workaround in #6151) or if the new composable logic should check the auth status for personal routes. |
I'm currently looking into building a composable that handles the authentication redirect. I'd like to avoid adding extra routes for public links. |
Description
This adds URL handling to the markdown editor. Allows us to return to the source folder of the file and to reopen the editor on page reload.
I copied a bit of code from the web-app-mediaviewer. Where can we share this kind of code?
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: