Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App provider create files #6312

Merged
merged 4 commits into from
Jan 25, 2022
Merged

App provider create files #6312

merged 4 commits into from
Jan 25, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jan 25, 2022

In order to avoid another rebase and review cycle this PR supersedes #5890

Description

Allow creation of files for mimetypes with set flag "allow_creation"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oC10SharingIntGroups https://drone.owncloud.com/owncloud/web/22166/28/1
The following scenarios passed on retry:

  • webUISharingInternalGroups/shareWithGroups.feature:255

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22166/15/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAcceptSharesToRoot-acceptShares_feature-L108.png

webUISharingAcceptSharesToRoot-acceptShares_feature-L108.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

12.2% 12.2% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Member Author

kulmann commented Jan 25, 2022

Code is not mine - if I could approve, I'd do it now. There is a backend issue, as described in #5890 - merging anyway to get the functionality in and not be blocked by the backend issue.

@kulmann kulmann merged commit d720459 into master Jan 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the app-provider-create-files branch January 25, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants