-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing changelog items, fix UI glitches, supersede dependabot PRs #6386
Conversation
7a5f9de
to
f009f7e
Compare
v2.0.0
4de569b
to
0be809a
Compare
v2.0.0
c8d20da
to
fb65771
Compare
@@ -178,6 +179,9 @@ export default { | |||
methods: { | |||
getSectionClasses(index) { | |||
const classes = [] | |||
if (this.menuSections.length === 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By now I'd prefer a restructuring of all the different conditions into 0) early return, 1) handling of the paddings and 2) handling of the borders. If think what we want to have is:
0) early return
if (!this.menuSections.length) {
return classes
}
1) handling of paddings
if (index < this.menuSections.length - 1) {
classes.push('oc-pb-s')
}
if (index > 0) {
classes.push('oc-pt-s')
}
Which means that all sections except the last get a bottom padding and all sections except the first get a top padding. For all sections in between the first and last sections this essentially boils down to oc-py-s
but with less special case handling logic.
2) handling of borders
if (index < this.menuSections.length - 1) {
classes.push('oc-files-context-actions-border')
}
Which adds the bottom border for visual separation of sections to all sections except the last (and skips it entirely if you only have 1 section).
a70feb5
to
5ea3762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
5ea3762
to
563795a
Compare
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22592/15/1 💥 The acceptance tests pipeline failed. The build has been cancelled. |
Add changelog, remove duplicate text-decoration
563795a
to
3e22924
Compare
Two minor translation tweaks Update sidebarnav snapshots
3e22924
to
c476a6a
Compare
Kudos, SonarCloud Quality Gate passed! |
Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/22602/41/1
|
Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22602/60/1
|
Description
PR to collect various things (missing changelog items, dropped commits from force-pushes, CSS one-line-fixes, translations improvements, ...) for the
v5.0.0
releaseRelated Issue