Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changelog items, fix UI glitches, supersede dependabot PRs #6386

Merged
merged 9 commits into from
Feb 9, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Feb 8, 2022

Description

PR to collect various things (missing changelog items, dropped commits from force-pushes, CSS one-line-fixes, translations improvements, ...) for the v5.0.0 release

Related Issue

@pascalwengerter pascalwengerter changed the title Log FontAwesome attribution, add changelog for theme.logo.sidebar => theme.logo.topbar Add missing changelog items, fix UI glitches Feb 8, 2022
@pascalwengerter pascalwengerter changed the title Add missing changelog items, fix UI glitches Add missing changelog items, fix UI glitches, bump SDK to official v2.0.0 Feb 8, 2022
@pascalwengerter pascalwengerter changed the title Add missing changelog items, fix UI glitches, bump SDK to official v2.0.0 Add missing changelog items, fix UI glitches, supersede depdendabot PRs Feb 8, 2022
@pascalwengerter pascalwengerter changed the title Add missing changelog items, fix UI glitches, supersede depdendabot PRs Add missing changelog items, fix UI glitches, supersede dependabot PRs Feb 8, 2022
@pascalwengerter pascalwengerter force-pushed the small-fixes-for-v5 branch 2 times, most recently from c8d20da to fb65771 Compare February 9, 2022 09:25
@pascalwengerter pascalwengerter mentioned this pull request Feb 9, 2022
24 tasks
@pascalwengerter pascalwengerter marked this pull request as ready for review February 9, 2022 10:29
@kulmann kulmann self-requested a review February 9, 2022 10:39
changelog/unreleased/enhancement-context-route-params Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-context-route-params Outdated Show resolved Hide resolved
changelog/unreleased/changelog-drop-ie-support Outdated Show resolved Hide resolved
@@ -178,6 +179,9 @@ export default {
methods: {
getSectionClasses(index) {
const classes = []
if (this.menuSections.length === 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By now I'd prefer a restructuring of all the different conditions into 0) early return, 1) handling of the paddings and 2) handling of the borders. If think what we want to have is:

0) early return

if (!this.menuSections.length) {
  return classes
}

1) handling of paddings

if (index < this.menuSections.length - 1) {
  classes.push('oc-pb-s')
}
if (index > 0) {
  classes.push('oc-pt-s')
}

Which means that all sections except the last get a bottom padding and all sections except the first get a top padding. For all sections in between the first and last sections this essentially boils down to oc-py-s but with less special case handling logic.

2) handling of borders

if (index < this.menuSections.length - 1) {
  classes.push('oc-files-context-actions-border')
}

Which adds the bottom border for visual separation of sections to all sections except the last (and skips it entirely if you only have 1 section).

packages/web-runtime/themes/owncloud/theme.json Outdated Show resolved Hide resolved
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22592/15/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAcceptSharesToRoot-acceptShares_feature-L108.png

webUISharingAcceptSharesToRoot-acceptShares_feature-L108.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

Two minor translation tweaks

Update sidebarnav snapshots
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

64.3% 64.3% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/22602/41/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:387

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22602/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@pascalwengerter pascalwengerter merged commit 71eed38 into master Feb 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the small-fixes-for-v5 branch February 9, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown editor doesn't scroll well and hides the app bar (save and close buttons)
4 participants