Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variable name in error object #6413

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix variable name in error object #6413

merged 1 commit into from
Feb 11, 2022

Conversation

individual-it
Copy link
Member

Description

the variable name should be error.resourceName, error.resource is not used anywhere

Related Issue

Motivation and Context

found when cleaning up unit test log messages:

  console.warn
    Cannot evaluate expression: resourceName

      356 |         title = this.$gettext('Failed to move "%{resourceName}"')
      357 |         this.showMessage({
    > 358 |           title: this.$gettextInterpolate(title, { resourceName: errors[0]?.resourceName }, true),
          | ^
      359 |           status: 'danger'
      360 |         })
      361 |         return

      at Object.evalInContext (node_modules/vue-gettext/dist/vue-gettext.js:280:21)
      at node_modules/vue-gettext/dist/vue-gettext.js:293:28
          at String.replace (<anonymous>)
      at Function.interpolate (node_modules/vue-gettext/dist/vue-gettext.js:247:24)
      at _callee5$ (packages/web-app-files/src/views/Personal.vue:358:1)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:63:40)
      at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:293:22)

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/22648/42/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:378

@ownclouders
Copy link
Contributor

Results for oC10SharingPermToRoot https://drone.owncloud.com/owncloud/web/22648/35/1
The following scenarios passed on retry:

  • webUISharingPermissionToRoot/sharePermissionsUsers.feature:113

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22648/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:253

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find and fix, thank you! 💪 Small small nitpicks, see comments below.

changelog/unreleased/bugfix-error-message-move Outdated Show resolved Hide resolved
packages/web-app-files/tests/unit/views/Personal.spec.js Outdated Show resolved Hide resolved
@individual-it
Copy link
Member Author

@dschmidt @kulmann thank you for your reviews, that have been rubbish mistakes. I've fixed them, please review again

@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22673/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@kulmann kulmann merged commit 35549d9 into master Feb 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the fixErrorMessageMoveItem branch February 11, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moving item by drag-and-drop doesn't show the resource name in the error message
4 participants