Use the Vue store for spaces #6427
Conversation
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22694/66/1
|
JammingBen
force-pushed
the
spaces-store
branch
from
26e2ba5
to
fe08de3
Compare
| fileId: '', | ||
| mimeType: '', |
There was a problem hiding this comment.
Do we need those fields, afaik they will never be set
There was a problem hiding this comment.
Depends on how the respective fields are used throughout the code. Sometimes there are string modifications applied - which don't work on undefined. IMO ok to keep them defined and empty, like it's done here. Will be cleaned up anyway once we refactor this to TypeScript.
| if (!path) { | ||
| loadReadmeTask.perform(ref) | ||
| loadImageTask.perform(ref) | ||
| } |
| fileId: '', | ||
| mimeType: '', |
There was a problem hiding this comment.
Depends on how the respective fields are used throughout the code. Sometimes there are string modifications applied - which don't work on undefined. IMO ok to keep them defined and empty, like it's done here. Will be cleaned up anyway once we refactor this to TypeScript.
packages/web-app-files/src/mixins/spaces/actions/editDescription.js
Outdated
Show resolved
Hide resolved
AlexAndBear
force-pushed
the
spaces-store
branch
from
23bc9f5
to
7451b20
Compare
|
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/22718/67/1 |
|
Kudos, SonarCloud Quality Gate passed! |
|
Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/22721/69/1
|
Description
Using the store for spaces integrates them seamlessly in our ecosystem and makes it easier to develop spaces even further. E.g. the properties of a space can now be altered without fetching all spaces again. This was achieved by introducing a "buildSpace" method, that transforms a space into a more generic resource object (just like regular files or shares).
Motivation and Context
Groundwork for #6284 (and basically all space-related issues)
Types of changes
Checklist: