Do not load files from cache #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for oCISSharingPerm2 https://drone.owncloud.com/owncloud/web/22851/64/1 |
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/22874/16/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIMarkdownEditor-markdownFile_feature-L21.pngwebUIMarkdownEditor-markdownFile_feature-L29.pngwebUIMarkdownEditor-markdownFile_feature-L44.png |
pascalwengerter
approved these changes
Feb 24, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23045/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-24-06-52-48.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-creates-public-link-to-a-folder-alice-2022-2-24-06-53-54.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-shares-file-to-brian-alice-2022-2-24-06-55-04.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-shares-folder-with-file-to-brian-alice-2022-2-24-06-56-14.zip |
pascalwengerter
changed the base branch from
master
to
transfer-no-drawio-cache
Closed
pascalwengerter
pushed a commit
that referenced
this pull request
Feb 24, 2022
* Do not load files from cache * changelog
Closed
phil-davis
pushed a commit
that referenced
this pull request
Feb 28, 2022
* Do not load files from cache * changelog
kiranparajuli589
pushed a commit
that referenced
this pull request
Mar 2, 2022
* Do not load files from cache * changelog
kiranparajuli589
pushed a commit
that referenced
this pull request
Mar 9, 2022
* Do not load files from cache * changelog
kiranparajuli589
pushed a commit
that referenced
this pull request
Mar 10, 2022
* Do not load files from cache * changelog
kiranparajuli589
pushed a commit
that referenced
this pull request
Mar 16, 2022
* Do not load files from cache * changelog
kiranparajuli589
pushed a commit
that referenced
this pull request
Mar 23, 2022
* Do not load files from cache * changelog
dschmidt
pushed a commit
that referenced
this pull request
Apr 26, 2022
* Do not load files from cache * changelog
11 tasks
pascalwengerter
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Do not load files from cache (#6447) * Do not load files from cache * changelog * Workaround CORS issue until owncloud/core#40024 is merged and released * Update changelog with further information on Cache-Control header Co-authored-by: Diogo Castro <diogo.castro@cern.ch> Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de>
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When apps (i.e Drawio) try to load a file, the browser caches the request.
If the file was modified somewhere else, this causes inconsistent results which prevent saving any changes until the cache is properly cleared.
We had observed this is the past in our text editor, hence the
noCacheaddition to the SDK. Now we also saw it in Drawio.